From: Tay Ray Chuan <rctay89@gmail.com>
To: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] ls-remote: fall-back to default remotes when no remote specified
Date: Fri, 9 Apr 2010 17:15:51 +0800 [thread overview]
Message-ID: <g2ube6fef0d1004090215uefd96052w64de7233c26002ae@mail.gmail.com> (raw)
In-Reply-To: <A612847CFE53224C91B23E3A5B48BAC7448206860D@xmail3.se.axis.com>
Hi,
On Fri, Apr 9, 2010 at 4:49 PM, Peter Kjellerstedt
<peter.kjellerstedt@axis.com> wrote:
>> From: git-owner@vger.kernel.org [mailto:git-owner@vger.kernel.org] On
>> Behalf Of Tay Ray Chuan
>> static const char ls_remote_usage[] =
>> -"git ls-remote [--heads] [--tags] [-u <exec> | --upload-pack <exec>] <repository> <refs>...";
>> + "git ls-remote [--heads] [--tags] [-u <exec> | --upload-pack <exec>]\n"
>> +" [<repository> [<refs>...]]";
>
> That should be:
>
> static const char ls_remote_usage[] =
> "git ls-remote [--heads] [--tags] [-u <exec> | --upload-pack <exec>]\n"
> " [<repository> [<refs>...]]";
>
> or the second line of the usage will not be indented as intended.
Nope, you are not right - you didn't take into account the "usage: "
string that is prepended. (The non-printed whitespace in front of "git
ls-remote..." is equivalent to that string.)
--
Cheers,
Ray Chuan
prev parent reply other threads:[~2010-04-09 9:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 3:58 [PATCH] ls-remote: default to 'origin' when no remote specified Tay Ray Chuan
2010-04-08 4:45 ` Jeff King
2010-04-08 5:35 ` Junio C Hamano
2010-04-08 6:25 ` Jeff King
2010-04-08 6:07 ` Tay Ray Chuan
2010-04-08 6:34 ` Jeff King
2010-04-08 6:44 ` Junio C Hamano
2010-04-08 6:47 ` Jeff King
2010-04-08 5:05 ` Junio C Hamano
2010-04-08 5:58 ` Tay Ray Chuan
2010-04-08 7:05 ` [PATCH v2] ls-remote: fall-back to default remotes " Tay Ray Chuan
2010-04-08 7:07 ` [PATCH v2 (resend)] " Tay Ray Chuan
2010-04-08 7:16 ` Jeff King
2010-04-08 17:10 ` Tay Ray Chuan
2010-04-08 17:21 ` [PATCH v3] " Tay Ray Chuan
2010-04-08 19:19 ` Jeff King
2010-04-09 8:49 ` Peter Kjellerstedt
2010-04-09 9:15 ` Tay Ray Chuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g2ube6fef0d1004090215uefd96052w64de7233c26002ae@mail.gmail.com \
--to=rctay89@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=peter.kjellerstedt@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).