From: Sverre Rabbelier <srabbelier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Johan Herland <johan@herland.net>,
David Aguilar <davvid@gmail.com>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] Makefile: Remove excess backslashes from sed
Date: Fri, 9 Apr 2010 17:34:15 +0200 [thread overview]
Message-ID: <g2xfabb9a1e1004090834y7d9c05f0xf09ef7f5c34c3ab7@mail.gmail.com> (raw)
In-Reply-To: <7vvdc12mmz.fsf@alter.siamese.dyndns.org>
Heya,
On Fri, Apr 9, 2010 at 07:57, Junio C Hamano <gitster@pobox.com> wrote:
> I wonder if we can make this a lot simpler to avoid multi-line sed script.
> For example, we could write the source Python script to always begin with:
>
> #!/usr/bin/python
> import sys;
> import os;
> sys.path.insert(0, os.getenv("GITPYTHONLIB","."));
Thank you, I like this a lot better than our current approach. I think
it's very ugly that git (needs to) mangle(s) the python files when
installing, since that means that line-numbers don't match in
stacktraces. I'd definitely prefer using this.
--
Cheers,
Sverre Rabbelier
next prev parent reply other threads:[~2010-04-09 15:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 3:22 [PATCH] Makefile: Remove excess backslashes from sed Brian Gernhardt
2010-04-09 5:57 ` Junio C Hamano
2010-04-09 8:02 ` David Aguilar
2010-04-09 8:42 ` [PATCH] Makefile: Avoid multi-line sed when building python scripts David Aguilar
2010-04-09 14:33 ` [PATCH] Makefile: Remove excess backslashes from sed Brian Gernhardt
2010-04-09 15:34 ` Sverre Rabbelier [this message]
2010-04-09 15:35 ` [PATCH] Makefile: Simplify handling of python scripts Brian Gernhardt
2010-04-09 6:04 ` [PATCH] Makefile: Remove excess backslashes from sed David Aguilar
-- strict thread matches above, loose matches on Subject: below --
2010-04-09 14:41 Brian Gernhardt
2010-04-09 14:44 ` Brian Gernhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=g2xfabb9a1e1004090834y7d9c05f0xf09ef7f5c34c3ab7@mail.gmail.com \
--to=srabbelier@gmail.com \
--cc=brian@gernhardtsoftware.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).