git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Edward Z. Yang" <edwardzyang@thewritingpot.com>
To: git@vger.kernel.org
Subject: core.autocrlf and merge conflict output
Date: Sun, 22 Jun 2008 18:08:59 -0400	[thread overview]
Message-ID: <g3miho$se5$1@ger.gmane.org> (raw)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Apparently, the conflict information Git writes to the working copy
during merge doesn't respect core.autocrlf, magically converting files
to LF and causing problems when you try to commit the files, when
core.safecrlf is on.

I'm in the process of making a patch, but I'm having difficulty getting
builtin-merge-file.c and convert.c to play together. Part of the problem
is the lack of documentation in convert.c, which I'd also like to fix
(but in a different patch).

So, here's an appeal to the Git gods:

* Should I even bother trying to document this? While good docs are
always a definite plus, poor documentation can hurt code.

* Would crlf_to_worktree (apparently an internal function) or
convert_to_working_tree be more appropriate for this task?

* Where can I get a sensible value for *path in convert.c from
builtin-merge-file.c?

Thanks!
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIXs17qTO+fYacSNoRAuAEAJ9LekfdUzU8WjbYxdhDOLaUfN67HACgg6gR
3kpT/5CbV3X7bbfkwJFDpAI=
=lega
-----END PGP SIGNATURE-----

             reply	other threads:[~2008-06-22 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-22 22:08 Edward Z. Yang [this message]
2008-06-23  0:45 ` core.autocrlf and merge conflict output Junio C Hamano
2008-06-23  1:47   ` Edward Z. Yang
2008-06-23  1:54     ` Junio C Hamano
2008-06-23  2:00     ` Johannes Schindelin
2008-06-23  2:23       ` Edward Z. Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='g3miho$se5$1@ger.gmane.org' \
    --to=edwardzyang@thewritingpot.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).