From: Dirk Gouders <dirk@gouders.net>
To: Andy Koppe <andy.koppe@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 2/4] utf8: fix comment for utf8_strnwidth()
Date: Thu, 19 Nov 2026 06:58:44 +0100 [thread overview]
Message-ID: <gh1p8hbbvv.fsf@gouders.net> (raw)
In-Reply-To: <CAHWeT-Zzvjx5knLdCdxUmn8zmkAk2qrzzvXkbSjhCibWy7hAeQ@mail.gmail.com>
On Wed, Nov 18 2026, Andy Koppe wrote:
> Dirk Gouders wrote:
>>
>> The comment for utf8_strnwidth() states it returns strlen() for cases
>> when the given string doesn't look like valid utf8, but it returns its
>> argument len in such cases.
>>
>> Fix the comment accordingly.
> …
>> /*
>> * Returns the total number of columns required by a null-terminated
>> - * string, assuming that the string is utf8. Returns strlen() instead
>> + * string, assuming that the string is utf8. Returns len instead
>> * if the string does not look like a valid utf8 string.
>> */
>> int utf8_strnwidth(const char *string, size_t len, int skip_ansi)
>
> "null-terminated" is wrong too.
Yes, I will fix that, too. Thank you.
Dirk
next prev parent reply other threads:[~2026-11-19 5:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 18:56 [PATCH 0/2] utf8: two minor fixes Dirk Gouders
2026-11-16 18:57 ` [PATCH 1/2] utf8: respect bounds in utf8_strnwidth() Dirk Gouders
2026-11-17 0:02 ` Junio C Hamano
2026-11-17 15:15 ` Dirk Gouders
2026-11-17 16:18 ` Junio C Hamano
2026-11-17 17:57 ` Dirk Gouders
2026-11-17 18:11 ` Junio C Hamano
2026-11-16 18:57 ` [PATCH 2/2] utf8: fix comment for utf8_strnwidth() Dirk Gouders
2026-11-18 21:08 ` [PATCH v2 0/4] utf8: bounds-related fixes and a doc fix Dirk Gouders
2026-11-18 21:08 ` [PATCH v2 1/4] utf8: add display_mode_esc_sequence_len_counted() Dirk Gouders
2026-11-19 5:54 ` Andy Koppe
2026-11-19 7:43 ` Dirk Gouders
2026-11-18 21:08 ` [PATCH v2 2/4] utf8: fix comment for utf8_strnwidth() Dirk Gouders
2026-11-18 22:40 ` Andy Koppe
2026-11-19 5:58 ` Dirk Gouders [this message]
2026-11-18 21:08 ` [PATCH v2 3/4] utf8: respect string boundaries after skipping ANSI escape sequences Dirk Gouders
2026-11-18 21:49 ` Junio C Hamano
2026-11-18 21:08 ` [PATCH v2 4/4] utf8: respect boundaries in utf8_strnwidth() Dirk Gouders
2026-11-18 21:50 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=gh1p8hbbvv.fsf@gouders.net \
--to=dirk@gouders.net \
--cc=andy.koppe@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox