Git development
 help / color / mirror / Atom feed
From: Dirk Gouders <dirk@gouders.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] doc/gitcli: minor fixes
Date: Sat, 14 Nov 2026 23:09:15 +0100	[thread overview]
Message-ID: <ghik1z6p6c.fsf@gouders.net> (raw)
In-Reply-To: <xmqqik1znkn8.fsf@gitster.g>

On Sat, Nov 14 2026, Junio C Hamano wrote:

> Dirk Gouders <dirk@gouders.net> writes:
>
>> -This manual describes the convention used throughout Git CLI.
>> +This manual describes the conventions used throughout Git CLI.
>
> OK.
>
>> @@ -28,7 +28,7 @@ arguments.  Here are the rules:
>>     `v1.0` and `v2.0` are revisions and `arch/x86` and `include/asm-x86`
>>     are paths.
>>  
>> - * When an argument can be misunderstood as either a revision or a path,
>> + * When arguments can be misunderstood as either a revision or a path,
>>     they can be disambiguated by placing `--` between them.
>
> I would rather have left the subject as-is, and then rewrote the
> conclusion part to "it can be disambiguated by placing `--` before
> or arter it".  Once you start talking about multiple arguments, you
> would have to also reorder them so that all revs come first, then
> '--', and then all paths. 

Thank you for the quick review.

Yes, there were two possible fixes for this second detail.
I will send a v2 according to your suggestion.

Regards,

Dirk

>> @@ -76,8 +76,8 @@ you will.
>>  Here are the rules regarding the "flags" that you should follow when you are
>>  scripting Git:
>>  
>> - * Splitting short options to separate words (prefer `git foo -a -b`
>> -   to `git foo -ab`, the latter may not even work).
>> + * Split short options to separate words: prefer `git foo -a -b`
>> +   to `git foo -ab` (the latter may not even work).
>
> OK.
>
> Thanks.

      reply	other threads:[~2026-11-14 22:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 20:15 [PATCH 1/1] doc/gitcli: minor fixes Dirk Gouders
2026-11-14 21:55 ` Junio C Hamano
2026-11-14 22:09   ` Dirk Gouders [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ghik1z6p6c.fsf@gouders.net \
    --to=dirk@gouders.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox