git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vasyl' Vavrychuk <vvavrychuk@gmail.com>
To: git@vger.kernel.org
Subject: Re: [EGIT PATCH] Fixed trivial warnings. Mainly parametrized raw types,   added serialVersionUID, removed unnecessery throws.
Date: Mon, 05 Jan 2009 01:26:02 +0200	[thread overview]
Message-ID: <gjrgip$al9$1@ger.gmane.org> (raw)
In-Reply-To: <gjrcni$9q$1@ger.gmane.org>

Not sure what is right:
public abstract class AnyObjectId implements Comparable<ObjectId> {
or
public abstract class AnyObjectId implements Comparable<AnyObjectId> {

IMHO second, but class AnyObjectId contains some compareTo(ObjectId).

Also not sure if this bunch of changes is complete enough. Maybe it's better to make more fixes in this direction and then commit.

  parent reply	other threads:[~2009-01-04 23:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-04 22:20 [EGIT PATCH] Fixed trivial warnings. Mainly parametrized raw types, added serialVersionUID, removed unnecessery throws Vasyl' Vavrychuk
2009-01-04 23:04 ` Robin Rosenberg
2009-01-05  1:08   ` Vasyl' Vavrychuk
2009-01-05  1:13   ` Vasyl' Vavrychuk
2009-01-04 23:26 ` Vasyl' Vavrychuk [this message]
2009-01-05  2:19   ` Shawn O. Pearce
2009-01-06  0:54   ` Robin Rosenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gjrgip$al9$1@ger.gmane.org' \
    --to=vvavrychuk@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).