git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Levedahl <mlevedahl@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH] Define a version of lstat(2) specially for copy operation
Date: Tue, 17 Mar 2009 23:17:25 -0400	[thread overview]
Message-ID: <gppp48$5sc$1@ger.gmane.org> (raw)
In-Reply-To: 20090317213820.GC13458@blimp.localdomain

Alex Riesen wrote:

> So that Cygwin port can continue work around its supporting
> library and get access to its faked file attributes.
> 
> Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
> ---
> Junio C Hamano, Tue, Mar 17, 2009 21:42:31 +0100:
>> But isn't this something shops that do deploy Cygwin version of git want
>> to see fixed, so that they can have a site-wide policy implemented in the
> 
> Frankly, I doubt they know or care.

Please don't presume to speak for the world here. I have a not insignificant 
group of users, many on Cygwin, and we depend upon identical behavior 
between Linux and Cygwin versions of git. I maintain my own local build of 
git for my group, among other reasons is to disable the non-Posix lstat 
hack.  Using the Win32 lstat does not speed up git that much (maybe 20-30% 
in my experience) and this trade-off of compatibility vs being not quite so 
dreadfully slow is certainly not worth it for me. (Obviously, others have a 
different view, or this feature would not exist).

So, I strongly urge keeping the differences between POSIX/Linux git and 
Cygwin git as minimal as possible.

Mark Levedahl

  reply	other threads:[~2009-03-18  3:19 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-17 16:26 [PATCH] disable post-checkout test on Cygwin Alex Riesen
2009-03-17 16:52 ` Junio C Hamano
2009-03-17 16:59   ` Johannes Sixt
2009-03-17 20:28     ` Alex Riesen
2009-03-17 20:42       ` Junio C Hamano
2009-03-17 21:38         ` [PATCH] Define a version of lstat(2) specially for copy operation Alex Riesen
2009-03-18  3:17           ` Mark Levedahl [this message]
2009-03-18  7:22           ` Alex Riesen
2009-03-18  7:41           ` Junio C Hamano
2009-03-18  7:56             ` Johannes Sixt
2009-03-18  9:30               ` Junio C Hamano
2009-03-18 10:14                 ` Johannes Sixt
2009-03-18 18:56                   ` Junio C Hamano
2009-03-17 20:34   ` [PATCH] disable post-checkout test on Cygwin Alex Riesen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gppp48$5sc$1@ger.gmane.org' \
    --to=mlevedahl@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).