From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
To: git@vger.kernel.org
Subject: Re: gitweb sets incorrect <base> header
Date: Wed, 29 Apr 2009 11:22:13 +0200 [thread overview]
Message-ID: <gt9685$l9g$1@ger.gmane.org> (raw)
In-Reply-To: 877i15uf14.fsf@write-only.cryp.to
On Tuesday 28 April 2009 14:41, Peter Simons wrote:
> after a recent gitweb update to revision v1.6.3-rc3-12-gb79376c, the CGI now
> generates an incorrect <base> header. For example, the first "patch" on the
> page
>
> http://git.cryp.to/fastcgi/commitdiff/9ad9965b3fa293c458df14391f181f2f8f1197cd
>
> erroneously refer to http://git.cryp.to/cgi-bin/gitweb.cgi#patch1, but that
Both in Konqueror and Opera the patch link on that page refers to
http://git.cryp.to/fastcgi/patch/9ad9965b3fa293c458df14391f181f2f8f1197cd
which is quite correct.
> page doesn't exist. It appears that $base_url is not determined correctly.
>
> Does anyone have a clue how that problem can be fixed?
OTOH by looking at the source I see
<base href="http://git.cryp.to/cgi-bin/gitweb.cgi" />
which doesn't seem correct at all. Do you have something in the gitweb config
that may be hard-coding the base url?
--
Giuseppe "Oblomov" Bilotta
next prev parent reply other threads:[~2009-04-29 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 12:41 gitweb sets incorrect <base> header Peter Simons
2009-04-29 9:22 ` Giuseppe Bilotta [this message]
2009-04-29 9:33 ` Jakub Narebski
2009-04-30 10:06 ` Peter Simons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gt9685$l9g$1@ger.gmane.org' \
--to=giuseppe.bilotta@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).