From: jean-luc malet <jeanluc.malet@gmail.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] builtin-merge: add support for default merge options
Date: Fri, 2 Apr 2010 19:19:44 +0200 [thread overview]
Message-ID: <h2m1de9d39c1004021019sd8e8bf79ide3f0516353c069c@mail.gmail.com> (raw)
In-Reply-To: <76718491003190754l217e1247t16b7f1b9f39c6182@mail.gmail.com>
Is there someone that can review this patch and maybe include it into
next GIT release?
I think it is really usefull especially when used in company
environment where default policies have to be set
thanks and regards
JLM
On Fri, Mar 19, 2010 at 3:54 PM, Jay Soffian <jaysoffian@gmail.com> wrote:
> On Fri, Mar 19, 2010 at 10:19 AM, jean-luc malet
> <jeanluc.malet@gmail.com> wrote:
>> Hi!
>> I would like to know the status about this patch...
>> I think this is a useful feature to have a default configuration
>> settable for all branch.<name>.* options
>> thanks and regards
>
> I lost interest in it apparently. I see it's still marked in my TODO,
> but I haven't had any personal time to spend on git lately.
>
> j.
>
>> On Sat, Mar 7, 2009 at 8:31 PM, jean-luc malet <jeanluc.malet@gmail.com> wrote:
>>> as a user,
>>> 1) I looked how to override defaults, since merge seems to use --ff as
>>> default, I looked if there was any global config to override that.
>>> nothing found... so go back to google
>>> 2) I found on the web that we can set it using
>>> branch.branchname.mergeoptions so I said "what if I use a branch named
>>> *, the config file was correct and git didn't insult me so.... but not
>>> the expected result...
>>>
>>> since the commands have allready defaults builtin, why not storing
>>> thoses defaults in the config file? like this it's easier to update
>>> them or change the way git behave....
>>> JLM
>>>
>>> On Sat, Mar 7, 2009 at 8:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>>> Jay Soffian <jaysoffian@gmail.com> writes:
>>>>
>>>>> On Fri, Mar 6, 2009 at 7:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>>>>> I think it would be much better if you did not introduce a new
>>>>>> configuration merge.options which is not consistent with everything else
>>>>>> to begin with.
>>>>>>
>>>>>> Instead, if your addition was literally to allow saying things like this,
>>>>>> it would be much easier to understand.
>>>>>>
>>>>>> [branch "*"]
>>>>>> mergeoptions = ...
>>>>>> remote = origin
>>>>>> rebase = true
>>>>>
>>>>> Okay. That's probably a more invasive patch, because a lot more code
>>>>> paths look at [branch ...], but I'll look into it.
>>>>
>>>> Note that you do not have to cover branch.*.remote and other things in the
>>>> same patch. The first one could just handle branch.*.mergeoptions and you
>>>> can let later patches to implement the fallbacks for other variables.
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> KISS! (Keep It Simple, Stupid!)
>>> (garde le simple, imbécile!)
>>> "mais qu'est-ce que tu m'as pondu comme usine à gaz? fait des choses
>>> simples et qui marchent, espèce d'imbécile!"
>>> -----------------------------
>>> "Si vous pensez que vous êtes trop petit pour changer quoique ce soit,
>>> essayez donc de dormir avec un moustique dans votre chambre." Betty
>>> Reese
>>> http://www.grainesdechangement.com/citations.htm
>>>
>>
>>
>>
>> --
>> KISS! (Keep It Simple, Stupid!)
>> (garde le simple, imbécile!)
>> "mais qu'est-ce que tu m'as pondu comme usine à gaz? fait des choses
>> simples et qui marchent, espèce d'imbécile!"
>> -----------------------------
>> "Si vous pensez que vous êtes trop petit pour changer quoique ce soit,
>> essayez donc de dormir avec un moustique dans votre chambre." Betty
>> Reese
>> http://www.grainesdechangement.com/citations.htm
>>
>
--
KISS! (Keep It Simple, Stupid!)
(garde le simple, imbécile!)
"mais qu'est-ce que tu m'as pondu comme usine à gaz? fait des choses
simples et qui marchent, espèce d'imbécile!"
-----------------------------
"Si vous pensez que vous êtes trop petit pour changer quoique ce soit,
essayez donc de dormir avec un moustique dans votre chambre." Betty
Reese
http://www.grainesdechangement.com/citations.htm
prev parent reply other threads:[~2010-04-02 17:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-06 22:15 [PATCH 0/3] Re: how to have --no-ff be the default for all branch Jay Soffian
2009-03-06 22:15 ` [PATCH 1/3] config: add git_config_option_string() Jay Soffian
2009-03-06 22:15 ` [PATCH 2/3] builtin-merge: refactor to use git_config_option_string Jay Soffian
2009-03-06 22:15 ` [PATCH 3/3] builtin-merge: add support for default merge options Jay Soffian
2009-03-06 22:46 ` Junio C Hamano
2009-03-06 23:16 ` Jay Soffian
2009-03-07 0:44 ` [PATCH v2 " Jay Soffian
2009-03-07 0:58 ` [PATCH " Junio C Hamano
2009-03-07 1:56 ` Jay Soffian
2009-03-07 7:18 ` Junio C Hamano
2009-03-07 13:48 ` Jay Soffian
2009-03-07 19:31 ` jean-luc malet
2010-03-19 14:19 ` jean-luc malet
2010-03-19 14:54 ` Jay Soffian
2010-04-02 17:19 ` jean-luc malet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h2m1de9d39c1004021019sd8e8bf79ide3f0516353c069c@mail.gmail.com \
--to=jeanluc.malet@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).