From: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Johan Herland <johan@herland.net>, <git@vger.kernel.org>
Subject: Re: git filter-branch --filter-notes/--post-rewrite?
Date: Sun, 20 Mar 2011 23:55:59 +0100 [thread overview]
Message-ID: <hbf.20110320kak3@bombur.uio.no> (raw)
In-Reply-To: <201103181053.58969.trast@student.ethz.ch>
Thomas Rast writes:
>Johan Herland wrote:
>
>> Looking at git-rebase.sh (where it _is_ implemented), it seems to be a
>> matter of feeding "old_sha1 new_sha1" pairs into a "rewritten" file, and
>> then passing that file to the stdin of "git notes copy --for-rewrite=filter-
>> branch" (followed by passing the same file to the "post-rewrite" hook).
That appends to the notes history instead of replacing it, which seems
broken to me. So I'm doing fast-export <notes> | edit; fast-import.
> I had a patch for this back when post-rewrite was invented,
>
> http://thread.gmane.org/gmane.comp.version-control.git/139919/focus=139917
>
> but Hannes replied that it should grow a real notes filter, and while
> I dropped it there, I tend to agree with him. Feel free to pick it up
> again.
A notes filter would be nice, but I don't understand why there's no
post-rewrite hook or option to let us get at the rewrite info before
it is deleted. For one thing a notes filter might not do just what is
intended (as above), but one might want the mapping info for other
things too. E.g. just to save it in case there are mailings floating
around which refer to old commit IDs.
In any case, thanks for the answers. I guess I can live with copying
the git-filter-branch script when needed, it's not as if I run that
every day.
--
Hallvard
next prev parent reply other threads:[~2011-03-20 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 20:50 git filter-branch --filter-notes/--post-rewrite? Hallvard B Furuseth
2011-03-18 0:16 ` Johan Herland
2011-03-18 9:53 ` Thomas Rast
2011-03-20 22:55 ` Hallvard B Furuseth [this message]
2011-03-21 2:39 ` Johan Herland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=hbf.20110320kak3@bombur.uio.no \
--to=h.b.furuseth@usit.uio.no \
--cc=git@vger.kernel.org \
--cc=johan@herland.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).