From: Hallvard Breien Furuseth <h.b.furuseth@usit.uio.no>
To: git@vger.kernel.org
Subject: Test t9500 fails if Time::HiRes is missing
Date: Mon, 23 Jan 2012 05:50:23 +0100 (CET) [thread overview]
Message-ID: <hbf.20120123rqzg@bombur.uio.no> (raw)
t9500-gitweb-standalone-no-errors fails: Git 1.7.9.rc2/1.7.8.4, RHEL
6.2, Perl 5.10.1. Reverting 3962f1d756ab41c1d180e35483d1c8dffe51e0d1
fixes it. The commit expects Time::HiRes to be present, but RedHat
has split it out to a separate RPM perl-Time-HiRes. Better add a
comment about that, so it doesn't get re-reverted.
Or pacify the test and expect gitweb@RHEL-users to install the RPM:
--- git-1.7.9.rc2/t/gitweb-lib.sh~
+++ git-1.7.9.rc2/t/gitweb-lib.sh
@@ -113,4 +113,9 @@
test_done
}
+perl -MTime::HiRes -e 0 >/dev/null 2>&1 || {
+ skip_all='skipping gitweb tests, Time::HiRes module not available'
+ test_done
+}
+
gitweb_init
--
Hallvard
next reply other threads:[~2012-01-23 4:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 4:50 Hallvard Breien Furuseth [this message]
2012-01-23 5:39 ` Test t9500 fails if Time::HiRes is missing Hallvard Breien Furuseth
2012-01-23 9:42 ` Ævar Arnfjörð Bjarmason
2012-01-27 5:48 ` Junio C Hamano
2012-01-27 9:32 ` Ævar Arnfjörð Bjarmason
2012-01-27 9:18 ` Jakub Narębski
2012-01-27 10:15 ` Hallvard B Furuseth
2012-01-27 10:59 ` Jakub Narębski
2012-01-27 17:45 ` [PATCH] Revert "gitweb: Time::HiRes is in core for Perl 5.8" Jakub Narebski
2012-01-27 20:44 ` Junio C Hamano
2012-01-28 17:48 ` Jakub Narebski
2012-01-29 2:29 ` Ævar Arnfjörð Bjarmason
2012-01-29 2:21 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=hbf.20120123rqzg@bombur.uio.no \
--to=h.b.furuseth@usit.uio.no \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).