From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 2/2] t7508-status: test all modes with color
Date: Tue, 08 Dec 2009 12:10:58 +0100 [thread overview]
Message-ID: <hflc82$sf8$1@ger.gmane.org> (raw)
In-Reply-To: 39211ecec866882503d1188d359e1183341faeb1.1260266027.git.git@drmicha.warpmail.net
Michael J Gruber wrote:
> +decrypt_color () {
> + sed \
> + -e 's/.\[1m/<WHITE>/g' \
> + -e 's/.\[31m/<RED>/g' \
> + -e 's/.\[32m/<GREEN>/g' \
> + -e 's/.\[34m/<BLUE>/g' \
> + -e 's/.\[m/<RESET>/g'
> +}
Shouldn't this be better in test-lib.sh, or some common lib
(lib-color.sh or color-lib.sh; we are unfortunately a bit inconsistent
in naming here)?
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2009-12-08 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 10:12 [PATCH 0/2] Add a few more status tests Michael J Gruber
2009-12-08 10:12 ` [PATCH 1/2] t7508-status: status --porcelain ignores relative paths setting Michael J Gruber
2009-12-08 10:12 ` [PATCH 2/2] t7508-status: test all modes with color Michael J Gruber
2009-12-08 11:10 ` Jakub Narebski [this message]
2009-12-08 16:06 ` Michael J Gruber
2009-12-09 5:32 ` Junio C Hamano
2009-12-09 5:44 ` Junio C Hamano
2009-12-09 9:18 ` Michael J Gruber
2009-12-09 21:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hflc82$sf8$1@ger.gmane.org' \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).