From: "Neal Kreitzinger" <neal@rsss.com>
To: git@vger.kernel.org
Subject: interactive rebase editor pathname variable
Date: Thu, 13 May 2010 13:32:35 -0500 [thread overview]
Message-ID: <hshglg$p2q$1@dough.gmane.org> (raw)
Hi,
It appears that git-commit and git-tag pass a partial pathname to the
core.editor, e.g. ".git/COMMIT_EDITMSG" that is relative to the working tree
directory. However, git-rebase -i passes an absolute pathname to the
core.editor, e.g.
"home/someuser/someworkingtree/.git/rebase-merge/git-rebase-todo". This
causes problems in our shop because our proprietary editor cannot handle
pathnames beginning with a period (it translates the period to a slash) and
therefore our entry for core.editor is 'someeditor "$PWD/$1"'. This breaks
on git rebase -i when the $1 contains the full pathname. Can this be added
to the bugfix list for git to make the $1 value passed to core.editor by all
git commands to always be relative pathnames (or absolute pathnames). FWIW,
I prefer absolute pathnames because a config entry of 'someeditor $1' is
more straightforward than 'someeditor "$PWD/$1"'. (Note: the reason I must
pass $1 is because the editor runs on top of a runtime and is actually
called as 'someruntime someeditor "$1"')
v/r,
Neal
next reply other threads:[~2010-05-13 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 18:32 Neal Kreitzinger [this message]
2010-05-14 7:59 ` interactive rebase editor pathname variable Jonathan Nieder
2010-05-14 12:49 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hshglg$p2q$1@dough.gmane.org' \
--to=neal@rsss.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).