From: Ralf Ebert <info@ralfebert.de>
To: git@vger.kernel.org
Subject: Re: [PATCH v2] Do not unquote + into ' ' in URLs
Date: Fri, 06 Aug 2010 12:46:42 +0200 [thread overview]
Message-ID: <i3gp6i$qap$1@dough.gmane.org> (raw)
In-Reply-To: <201007312333.38471.trast@student.ethz.ch>
Hi,
> To be precise, if the client ever attempts to decode URLs with query
> strings (for whatever reasons) then it would break. Probably there
> are no such URLs, but I don't know for sure.
url_decode seems to be called only from connect.c to support
percent-encoding for git/ssh-URLs, so at least as of now, there should
be no problem here. Since applying the patch, git clone
'git://git.gnome.org/gtk+' works ok again for me.
Greetings,
Ralf
next prev parent reply other threads:[~2010-08-06 10:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 13:18 URL decoding changed semantics of + in URLs Thomas Rast
2010-07-23 13:21 ` Thomas Rast
2010-07-23 14:10 ` Ævar Arnfjörð Bjarmason
2010-07-23 14:25 ` Jasper St. Pierre
2010-07-23 21:23 ` [PATCH] Do not unquote + into ' ' " Thomas Rast
2010-07-23 22:20 ` Ævar Arnfjörð Bjarmason
2010-07-23 22:26 ` Junio C Hamano
2010-07-23 23:04 ` Thomas Rast
2010-07-24 14:49 ` [PATCH v2] " Thomas Rast
2010-07-31 21:18 ` Jasper St. Pierre
2010-07-31 21:33 ` Thomas Rast
2010-08-06 10:46 ` Ralf Ebert [this message]
2010-07-26 15:40 ` URL decoding changed semantics of + " Jeff King
2010-07-26 17:57 ` Ævar Arnfjörð Bjarmason
2010-07-26 18:22 ` Jasper St. Pierre
2010-07-26 18:30 ` Matthieu Moy
2010-07-26 18:35 ` Ævar Arnfjörð Bjarmason
2010-07-26 18:44 ` Jasper St. Pierre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='i3gp6i$qap$1@dough.gmane.org' \
--to=info@ralfebert.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).