From: WOLfgang Schricker <news@wols.org>
To: git@vger.kernel.org
Subject: Re: [RFC PATCH] gitweb.perl: tags snapshot link
Date: Tue, 14 Sep 2010 20:06:17 +0200 [thread overview]
Message-ID: <i6odiq$ire$1@dough.gmane.org> (raw)
In-Reply-To: <i6jnhg$epf$1@dough.gmane.org>
Giuseppe Bilotta wrote:
> WOLfgang Schricker wrote:
>
>> Hello,
>>
>> I missed a snapshot link in my local repo:
>> ====
>> tags
>> ====
>> tag | commit | shortlog | log | *snapshot*
>>
>> I found this threads
>>
>> <http://kerneltrap.org/mailarchive/git/2009/11/8/15785/thread>
>> <http://thread.gmane.org/gmane.comp.version-control.git/132366>
>>
>> and the code for "Smarter snapshot names" in 'gitwep.perl'.
>>
>> My gitweb.perl-1.7.2.2.patch for "activating":
>>
>>
>> --- gitweb.perl.orig 2010-08-20 01:44:47.000000000 +0200
>> +++ gitweb.perl 2010-09-03 13:20:40.000000000 +0200
>> @@ -4909,6 +4909,10 @@
>> } elsif ($tag{'reftype'} eq "blob") {
>> print " | " . $cgi->a({-href => href(action=>"blob_plain",
>> hash=>$tag{'refid'})}, "raw"); }
>> + my $snapshot_links = format_snapshot_links($tag{'fullname'});
>> + if (defined $snapshot_links) {
>> + print " | " . $snapshot_links;
>> + }
>> print "</td>\n" .
>> "</tr>";
>> }
>
> If I read the patch correctly, this would add a 'snapshot' link to the tag
> list view. Although the snapshot can already be obtained by clicking first
> on the commit or shortlog view, this would reduce the number of clicks
> necessary to obtain the snapshot. I believe it would be a good idea to have
> this. Wolfgang: wold you consider submitting it in a more appropriate form
> for inclusion?
>
> If you do, you should probably also consider other places where such a link
> could be added, such as in tag view, where the nav bar currently reads
>
> summary | shortlog | log | commit | commitdiff | tree
>
> and "| snapshot" could be appended.
>
Yes. _Every_ available snapshot link looks <project>-<SHA1>.tgz.
A 'v0.1' tag brings in the tag list project-v0.1.tgz now.
I see eg. a relocatable 'latest' tag for project-latest.tgz.
--
Regards
*WOL* fgang *S* chricker
prev parent reply other threads:[~2010-09-14 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-03 11:42 [RFC PATCH] gitweb.perl: tags snapshot link WOLfgang Schricker
2010-09-12 23:25 ` Giuseppe Bilotta
2010-09-14 18:06 ` WOLfgang Schricker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='i6odiq$ire$1@dough.gmane.org' \
--to=news@wols.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).