git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sverre Rabbelier <srabbelier@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: am: be more helpful
Date: Sat, 10 Apr 2010 01:31:42 +0200	[thread overview]
Message-ID: <j2yfabb9a1e1004091631v40226a94kbad5512e9439c65d@mail.gmail.com> (raw)
In-Reply-To: <7v4ojk1a1i.fsf@alter.siamese.dyndns.org>

Heya,

On Sat, Apr 10, 2010 at 01:27, Junio C Hamano <gitster@pobox.com> wrote:
> Sverre Rabbelier <srabbelier@gmail.com> writes:
>> I run into this problem every now and then when I manually apply a
>> patch. I apply it, do some stuff, and then having forgotten I already
>> applied it, try to apply it again, and am confused as to why it won't
>> apply. Would it be difficult to teach 'git am' to see if the patch-id
>> of the patch that couldn't be applied has been applied already
>> (similar to what 'git cherry' does I guess?) and print a helpful
>> message saying "warning: patch already applied" when there is a
>> conflict trying to apply such an already-applied patch?
>
> "am -3"?

"Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
No changes -- Patch already applied."

Yeah, that's pretty much what I want, only I'd like to get that as a
warning when running 'git am' without the -3. Either that, or have -3
be the default, which we all know won't happen :P. If I'd realize that
perhaps I'd already applied the patch I could indeed use 'git am -3'
to check that, or, as I do now (after a few minutes of confusion),
scroll up and notice that I'd already applied it. What I want is to
save me those minutes of confusion by having git DWIW.

-- 
Cheers,

Sverre Rabbelier

      reply	other threads:[~2010-04-09 23:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-09 22:59 am: be more helpful Sverre Rabbelier
2010-04-09 23:27 ` Junio C Hamano
2010-04-09 23:31   ` Sverre Rabbelier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=j2yfabb9a1e1004091631v40226a94kbad5512e9439c65d@mail.gmail.com \
    --to=srabbelier@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).