Git development
 help / color / mirror / Atom feed
From: jasmeet.bhatia.us@gmail.com
To: phillip.wood@dunelm.org.uk
Cc: git@vger.kernel.org, deveshigurgaon@gmail.com, gitster@pobox.com,
	ps@pks.im, leonmichalak6@gmail.com
Subject: Re: [PATCH] stash: reuse prepared state when creating stash
Date: Mon, 09 Nov 2026 05:09:19 +0000	[thread overview]
Message-ID: <jerc-18e648444c4a0fd6-bf304-0@gmail.com> (raw)
In-Reply-To: <845be1de-8d12-41c9-996d-038886bde4cf@gmail.com>

Hi Phillip,

On Mon Nov 2, 2026 at 6:14 AM -08:00, Phillip Wood wrote:

> I've got some patches in "seen" [1] that take a slightly different 
> approach and keep the call to check_changes() in do_create_stash() and 
> remove it from create_stash() and do_push_stash() instead. That series 
> also removes a number of unnecessary calls to preload_index(). If you 
> have time to post a review that would be really helpful.

Thanks for the opportunity to contribute! I'll take a look in the coming days and let you know any thoughts I have.

Thanks,

Jazz

      reply	other threads:[~2026-11-09  5:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31 20:01 [PATCH] stash: reuse prepared state when creating stash jasmeet.bhatia.us
2026-11-02 14:14 ` Phillip Wood
2026-11-09  5:09   ` jasmeet.bhatia.us [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jerc-18e648444c4a0fd6-bf304-0@gmail.com \
    --to=jasmeet.bhatia.us@gmail.com \
    --cc=deveshigurgaon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=leonmichalak6@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox