From: Stefan Monnier <monnier@iro.umontreal.ca>
To: git@vger.kernel.org
Subject: Re: Merge-Recursive Improvements
Date: Tue, 12 Feb 2008 18:03:00 -0500 [thread overview]
Message-ID: <jwv3arxairx.fsf-monnier+gmane.comp.version-control.git@gnu.org> (raw)
In-Reply-To: A21B3CA8-6240-434F-87A9-C6F76DA15265@gmail.com
> "ORIG_HEAD...MERGE_HEAD" diffs to see what was going on. I could use an
> external diff tool (yuck), but I would like to modify the conflict markers
> to resemble those of Perforce:
>>>>>>>> merge-base:file.txt
> Original code.
> ======= HEAD:file.txt
> Head code.
> ======= merge:file.txt
> Merged code.
> <<<<<<<
Having such 3-parts conflicts helps tremendously when you have to do
the merge by hand, so I'm 100% in favor of such a change.
BUT Please, please, pretty please, don't follow Perforce who blindly
disregards previous standards. Instead use the format used by diff3
which has been there for ages:
<<<<<<< foo
original text
||||||| bar
ancestor
=======
new text
>>>>>>> baz
> Third, git doesn't appear to have any sense of context when performing a
> merge. Another contrived example which wouldn't be flagged as a merge
> conflict:
> ptr = malloc(len); // Added in HEAD.
> init(); // Included in merge-base.
> ptr = malloc(len); // Added in "merge".
Yes, that's nasty.
> Fourth, git doesn't provide a mechanism for merges to ignore whitespace
> changes.
I can live with that. As long as the conflict is clearly marked with
all 3 parts, I can use any external tool I want to resolve the conflict.
Stefan
next prev parent reply other threads:[~2008-02-12 23:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-12 22:16 Merge-Recursive Improvements Voltage Spike
2008-02-12 23:03 ` Stefan Monnier [this message]
2008-02-12 23:11 ` Junio C Hamano
2008-02-12 23:48 ` Linus Torvalds
2008-02-13 0:05 ` Johannes Schindelin
2008-02-13 1:10 ` [PATCH] xdl_merge(): introduce XDL_MERGE_ZEALOUS_ALNUM Johannes Schindelin
2008-02-13 1:34 ` Junio C Hamano
2008-02-13 11:16 ` Johannes Schindelin
2008-02-15 17:32 ` Junio C Hamano
2008-02-15 18:17 ` Linus Torvalds
2008-02-15 18:23 ` Johannes Schindelin
2008-02-17 19:06 ` Johannes Schindelin
2008-02-17 19:07 ` [PATCH 1/2] xdl_merge(): make XDL_MERGE_ZEALOUS output simpler Johannes Schindelin
2008-02-17 19:07 ` [PATCH(RFC) 2/2] xdl_merge(): introduce XDL_MERGE_ZEALOUS_ALNUM Johannes Schindelin
2008-02-18 8:35 ` [PATCH 1/2] xdl_merge(): make XDL_MERGE_ZEALOUS output simpler Junio C Hamano
2008-02-18 11:33 ` Johannes Schindelin
2008-02-13 2:06 ` [PATCH] xdl_merge(): introduce XDL_MERGE_ZEALOUS_ALNUM Linus Torvalds
2008-02-13 11:22 ` Johannes Schindelin
2008-02-13 7:39 ` Merge-Recursive Improvements Johannes Sixt
2008-02-13 8:17 ` Steffen Prohaska
2008-02-13 8:21 ` Voltage Spike
2008-02-13 8:46 ` Johannes Sixt
2008-02-15 19:21 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv3arxairx.fsf-monnier+gmane.comp.version-control.git@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).