git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "norbert.nemec" <norbert.nemec@native-instruments.de>
To: git@vger.kernel.org
Subject: Re: git blame --follow
Date: Thu, 06 Sep 2012 12:12:42 +0200	[thread overview]
Message-ID: <k29sup$2e0$1@ger.gmane.org> (raw)
In-Reply-To: <20120906095804.GA15277@sigill.intra.peff.net>

Thanks for the explanation.

I actually do not have any clear opinion what it should do. Just that 
the current situation is confusing when experimenting and trying to 
understand the behavior of git blame and git log: an intuitive option 
that is accepted but ignored.

The option should either be rejected or do *something* documented and 
useful. Ideally, it should result in behavior that matches 'git log 
--follow' as closely as possible. So maybe, it should be a synonym for a 
certain number of "-C" options?

Greetings,
Norbert



Am 06.09.12 11:58, schrieb Jeff King:
> On Thu, Sep 06, 2012 at 09:02:17AM +0200, norbert.nemec wrote:
>
>> 'git blame --follow' seems to be undocumented. The exact behavior is
>> not clear to me. Perhaps an alias for some combination of '-C' and
>> '-M'? It seems not be be fully consistent with 'git log --follow'.
>>
>> Could someone clarify? Did I miss something?
>
> I don't think it was ever intended to do anything; the only reason it is
> not rejected outright is that "blame" piggy-backs on the regular
> revision option parser used by "log" and others.
>
> What would you expect it to do?
>
> I can't think of a sane behavior for "blame --follow". The follow code
> is about tweaking path-limiting during traversal, but blame does not use
> pathspecs. It tracks content, and the "-C" option already instructs it to
> look across file boundaries.
>
> -Peff
>

  reply	other threads:[~2012-09-06 10:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-06  7:02 git blame --follow norbert.nemec
2012-09-06  9:58 ` Jeff King
2012-09-06 10:12   ` norbert.nemec [this message]
2012-09-06 15:13     ` Jeff King
2012-09-19  2:48       ` [PATCH] Documentation/git-blame.txt: --follow is a NO-OP Drew Northup
2012-09-19  4:38         ` Junio C Hamano
2012-09-19 18:27           ` Jeff King
2012-09-19 19:36             ` Junio C Hamano
2012-09-19 19:42               ` Jeff King
2012-09-19 20:31                 ` Kevin Ballard
2012-09-19 20:37                   ` Jeff King
2012-09-19 21:09                     ` Kevin Ballard
2012-09-21 19:09                     ` Re* " Junio C Hamano
2012-09-21 21:00                       ` Junio C Hamano
2012-09-20  0:05                 ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2011-03-15 15:44 git blame --follow Wolfgang Rohdewald
2011-03-15 17:30 ` Junio C Hamano
2011-03-15 18:26   ` Wolfgang Rohdewald
2011-03-17  9:59     ` Jakub Narebski
2011-03-17 10:16       ` Wolfgang Rohdewald
2011-03-17 16:47         ` Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='k29sup$2e0$1@ger.gmane.org' \
    --to=norbert.nemec@native-instruments.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).