From: Avery Pennarun <apenwarr@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "David Martínez Martí" <desarrollo@gestiweb.com>,
git@vger.kernel.org, deavidsedice@gmail.com
Subject: Re: Possible bug in Git
Date: Thu, 15 Apr 2010 20:13:55 -0400 [thread overview]
Message-ID: <k2n32541b131004151713s51498b01s34c5a95c0f360901@mail.gmail.com> (raw)
In-Reply-To: <o2m32541b131004151706hb48a0d04yf7fa4238d423a4e3@mail.gmail.com>
On Thu, Apr 15, 2010 at 8:06 PM, Avery Pennarun <apenwarr@gmail.com> wrote:
> On Thu, Apr 15, 2010 at 8:01 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Avery Pennarun <apenwarr@gmail.com> writes:
>>
>>> So what git tries to do is reduce the diff output of a merge commit
>>> down to just the "unexpected" parts: the parts that are different from
>>> what you'd get if you just merged in the individual changes in the
>>> obvious way.
>>
>> This (and everything you said after this paragraph) is not quite correct.
>> What is shown is the pieces that do not match either of the parent.
>>
>> So if you have a conflicted merge and resolve it by taking what one side
>> did literally (think: "merge -X ours"), that hunk becomes uninteresting
>> because the end result matches what one of the parents had.
>
> Hmm, but David also said:
>
>>>> git show commit:path shows empty file:
>>>> $ git show dac6a95f5:facturacion/facturacion/scripts/lineasfacturascli.qs | wc
>>>> 0 0 0
>
> The output seems to match neither parent in any way, and yet the
> simplification has resulted in no diff at all. Strange, no?
>
> Avery
>
mkdir testy
cd testy
git init
cp /etc/profile .
git add profile
git commit -m root
git checkout -b a master
cat /etc/profile >>profile
git commit -a -m test1
git checkout -b b master
cat /etc/profile | tr A-Za-z a-zA-Z >profile
git commit -a -m test1b
git merge a
# produces a conflict
true >profile # blank the file
git commit -a -m resolved
git show HEAD:profile
# no output
Note that if you instead replace the file with a nonempty (but
different) file, you get something appropriate as the output.
Have fun,
Avery
next prev parent reply other threads:[~2010-04-16 0:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 10:47 Possible bug in Git David Martínez Martí
2010-04-15 12:59 ` [PATCH] combined diff: correctly handle truncated file Thomas Rast
2010-04-15 23:45 ` Possible bug in Git Avery Pennarun
2010-04-16 0:01 ` Junio C Hamano
2010-04-16 0:06 ` Avery Pennarun
2010-04-16 0:13 ` Avery Pennarun [this message]
2010-04-16 0:38 ` Jay Soffian
2010-04-16 0:45 ` Avery Pennarun
2010-04-16 15:53 ` Linus Torvalds
2010-04-16 16:39 ` Thomas Rast
2010-04-16 16:56 ` Junio C Hamano
2010-04-16 17:00 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k2n32541b131004151713s51498b01s34c5a95c0f360901@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=deavidsedice@gmail.com \
--cc=desarrollo@gestiweb.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).