From: Jon Seymour <jon.seymour@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Git Mailing List <git@vger.kernel.org>, spearce@spearce.org
Subject: Re: [PATCH v3 0/2] git-gui: change to display the combined diff in the case of conflicts.
Date: Wed, 31 Mar 2010 23:12:30 +1200 [thread overview]
Message-ID: <k2p2cfc40321003310412hf4c6d642n4349af3f644829ff@mail.gmail.com> (raw)
In-Reply-To: <4BB2F7A0.6020702@viscovery.net>
> I looked at the result, but it does not convince me. In my case, I have a
> large file that has many changes between the "maint" and "master"
> branches. Whenever there are conflicts after merging "maint" to "master",
> I see all these changes, and really they *are* uninteresting.
>
I think you may have missed the point of my patch.
The successfully merged lines may be uninteresting from the point of
deciding what I should *do* but they
are highly relevant to the question of what I really, really should *not* do.
If there are 100 successfully merged lines from each side of the merge
but only 2 conflicting lines, should I
a) pick the remote branch
b) pick the local branch
c) manually edit the conflicting line (or use a merge tool)
The point of my patch it to make it much more likely that you will pick c).
In the current state, the GUI doesn't make it clear that either a) or
b) is almost certainly a huge mistake.
Now, you could disable Use Remote and Use Local for all but the very
simplest cases - but you don't need it for these
cases. Hell, ed would do for these.
jon.
next prev parent reply other threads:[~2010-03-31 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 15:34 [PATCH v3 0/2] git-gui: change to display the combined diff in the case of conflicts Jon Seymour
2010-03-31 7:20 ` Johannes Sixt
2010-03-31 11:12 ` Jon Seymour [this message]
2010-03-31 11:39 ` Johannes Sixt
2010-03-31 11:50 ` Jon Seymour
2010-03-31 12:23 ` Jon Seymour
2010-03-31 13:51 ` Johannes Sixt
2010-03-31 19:52 ` Jon Seymour
2010-04-02 8:37 ` Johannes Sixt
2010-04-04 6:44 ` Jon Seymour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=k2p2cfc40321003310412hf4c6d642n4349af3f644829ff@mail.gmail.com \
--to=jon.seymour@gmail.com \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).