From: "Joachim Schmitz" <jojo@schmitz-digital.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability
Date: Tue, 9 Oct 2012 09:15:25 +0200 [thread overview]
Message-ID: <k50iuv$j0b$1@ger.gmane.org> (raw)
In-Reply-To: 7vd30snbtk.fsf@alter.siamese.dyndns.org
Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Ben Walton <bdwalton@gmail.com> writes:
>>
>>> Avoid a GNU-ism in the cp options used by t5400-send-pack. Change
>>> -a
>>> to -pR.
>>>
>>> Signed-off-by: Ben Walton <bdwalton@gmail.com>
>>> ---
>>
>> Thanks, but is "-p" essential for this test to pass, or can we get
>> away with just "-R"?
>
> Besides, when you spot a potential problem, please ask "git grep"
> to catch them all.
>
> $ git grep "cp -a" t/
> t/t5400-send-pack.sh: cp -a parent child &&
> t/t5550-http-fetch.sh: cp -a
> .git"$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
> t/t5800-remote-helpers.sh: cp -a server server2 &&
There's 2 more places in Documentation/git-tutorial.txt. There it looks like
we'd want to use 'cp -pR' instead
Bye, Jojo
prev parent reply other threads:[~2012-10-09 7:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 8:08 [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability Ben Walton
2012-10-08 16:35 ` Junio C Hamano
2012-10-08 16:55 ` Junio C Hamano
2012-10-08 17:45 ` Junio C Hamano
2012-10-08 20:05 ` Ben Walton
2012-10-08 21:19 ` Junio C Hamano
2012-10-09 7:15 ` Joachim Schmitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='k50iuv$j0b$1@ger.gmane.org' \
--to=jojo@schmitz-digital.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).