From: "Joachim Schmitz" <jojo@schmitz-digital.de>
To: git@vger.kernel.org
Subject: Re: [PATCH] fast-import: Remove redundant assignment of 'oe' to itself.
Date: Tue, 28 May 2013 10:22:05 +0200 [thread overview]
Message-ID: <ko1pfi$7f6$1@ger.gmane.org> (raw)
In-Reply-To: 51A26BB7.3060702@gmail.com
Stefano Lattarini wrote:
> On 05/26/2013 10:05 PM, Stefan Beller wrote:
>> Reported by cppcheck.
>>
>> Signed-off-by: Stefan Beller <stefanbeller@googlemail.com>
>> ---
>> fast-import.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fast-import.c b/fast-import.c
>> index 5f539d7..0142e3a 100644
>> --- a/fast-import.c
>> +++ b/fast-import.c
>> @@ -2914,7 +2914,7 @@ static void cat_blob(struct object_entry *oe,
>> unsigned char sha1[20]) static void parse_cat_blob(void)
>> {
>> const char *p;
>> - struct object_entry *oe = oe;
>>
> This was done on purpose, to avoid spurious warnings with (at least)
> some versions of GCC.
>
>> + struct object_entry *oe;
>> unsigned char sha1[20];
>>
>> /* cat-blob SP <object> LF */
>
This strange construct has been removed in other places meanwhile. It is
violating C-standards (C89, C99) and as such causes warnings with other
compilers, so this is fighting fire with fire. As it is a pointer it may be
more sensible to initialize with NULL, should appease all compilers and
still be correct.
Bye, Jojo
prev parent reply other threads:[~2013-05-28 8:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-26 20:05 [PATCH] fast-import: Remove redundant assignment of 'oe' to itself Stefan Beller
2013-05-26 20:08 ` Stefano Lattarini
2013-05-26 20:14 ` Stefan Beller
2013-05-26 20:17 ` Stefano Lattarini
2013-05-26 20:23 ` Stefan Beller
2013-05-28 8:22 ` Joachim Schmitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='ko1pfi$7f6$1@ger.gmane.org' \
--to=jojo@schmitz-digital.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).