git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tor Arntsen <tor@spacetec.no>
To: "Gary V. Vaughan" <git@mlists.thewrittenword.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/5] Dangling commas in enum is not portable (resend)
Date: Sun, 25 Apr 2010 15:12:37 +0200	[thread overview]
Message-ID: <l2od2d39d861004250612g9ac6c7b4qdaa8ce0f973846e7@mail.gmail.com> (raw)
In-Reply-To: <20100315031718.GA21130@thor.il.thewrittenword.com>

On Sun, Apr 25, 2010 at 10:35, Gary V. Vaughan
<git@mlists.thewrittenword.com> wrote:

> I take it back.  I've been porting this patch forward from our builds
> of previous releases, and at some point it certainly was necessary
> (otherwise I wouldn't have written the patch)... and yet, all of our
> platforms are now able to compile a minimal test program in C.
> Either the offending vendor compilers have issued an update to accept
> the dangling comma syntax, or we have retired the machines that used
> to have this problem since I originally wrote the patch.
>
> It's notable that aCC (the HP C++ compiler) and CC (the SunOS C++
> compiler) both issue a warning on dangling enum commas, but even they
> still compile successfully.
>
> Sorry for the noise,

The SGI MIPS Compiler v6.2 on IRIX 6.2 compiles, but with a warning.
Later MIPSPro 7.2 and 7.4 versions (on 6.5) are OK (silent)
Unfortunately IBM VisualAge C 5.0 (I have 5.0.2) on AIX 5.1 fails to
compile with a trailing comma.
IBM XLC V10.1 (I have one on AIX 6.1) is OK (silent)
Native compiler on Tru64 V5.1 is OK (silent)

So, from the boxes I have access to the IBM XLC V5 version is the one
which has a problem.

-Tor

  reply	other threads:[~2010-04-25 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11 16:32 [PATCH 3/5] Dangling commas in enum is not portable (resend) Gary V. Vaughan
2010-03-12  9:18 ` Felipe Contreras
2010-04-25  8:35   ` Gary V. Vaughan
2010-04-25 13:12     ` Tor Arntsen [this message]
2010-04-25 16:03       ` Gary V. Vaughan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=l2od2d39d861004250612g9ac6c7b4qdaa8ce0f973846e7@mail.gmail.com \
    --to=tor@spacetec.no \
    --cc=felipe.contreras@gmail.com \
    --cc=git@mlists.thewrittenword.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).