Git development
 help / color / mirror / Atom feed
From: Maik Beckmann <maikbeckmann@gmx.de>
To: git@vger.kernel.org
Subject: gitk: possible bug in diffcmd
Date: Sat, 5 Jan 2008 09:41:35 +0000 (UTC)	[thread overview]
Message-ID: <loom.20080105T093532-817@post.gmane.org> (raw)

Hello.  

I'm using git-1.5.3.7 on linux.  

When I try get use "Make Patch" from by the context menu and click on "Generate"
an error popup appears which states: 
  "Error creating patch: illegal use of | or &|"
I tracked the problem down to line 5064 in gitk, which belongs to diffcmd: 
  set cmd [concat | git diff-tree -r $flags $ids]  
This line produces something like 
  | git diff-tree -r -p 5441937e2... 7394db226...  
As you see there is a leading pipe symbol which caused the error message.  
Is there some special shell to use with gitk?? Or is it just a BUG?

If I remove the | after concat everything works smooth.

Thanks in advance,

 -- Maik

                 reply	other threads:[~2008-01-05  9:45 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20080105T093532-817@post.gmane.org \
    --to=maikbeckmann@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox