Git development
 help / color / mirror / Atom feed
From: Eric Raible <raible@gmail.com>
To: git@vger.kernel.org
Subject: Re: What is 'git BRANCH'?
Date: Tue, 29 Jul 2008 23:45:00 +0000 (UTC)	[thread overview]
Message-ID: <loom.20080729T233158-95@post.gmane.org> (raw)
In-Reply-To: 7v63qob9hz.fsf@gitster.siamese.dyndns.org

Junio C Hamano <gitster <at> pobox.com> writes:

> diff --git a/git.c b/git.c
> index 37b1d76..c99e769 100644
> --- a/git.c
> +++ b/git.c
> @@ -448,7 +448,7 @@ int main(int argc, const char **argv)
>  		cmd += 4;
>  		argv[0] = cmd;
>  		handle_internal_command(argc, argv);
> -		die("cannot handle %s internally", cmd);
> +		help_unknown_cmd(cmd);
>  	}

Which on windows leads to the less-than-friendly:

git BRANCH =>
git: 'BRANCH.exe' is not a git-command. See 'git --help'.

I wonder if it wouldn't be better to simply to a case-insensitive
comparison when comparing against the builtin array.  Alternatively,
at least the the extension (if any) ought to be stripped.

I'd be glad to come up with the patch for either given the word...

- Eric

      parent reply	other threads:[~2008-07-29 23:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-29 22:18 What is 'git BRANCH'? Jurko Gospodnetić
2008-07-29 22:24 ` Junio C Hamano
2008-07-29 22:32   ` Kevin Ballard
2008-07-29 22:43     ` Jurko Gospodnetić
2008-07-29 22:39   ` Junio C Hamano
2008-07-29 22:49     ` Sverre Rabbelier
2008-07-30  5:14       ` Jeff King
2008-07-29 23:45     ` Eric Raible [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=loom.20080729T233158-95@post.gmane.org \
    --to=raible@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox