From: "Michał Kiedrowicz" <michal.kiedrowicz@gmail.com>
To: git@vger.kernel.org
Subject: Re: t7810.94 (git-grep -E -F -G) never passed
Date: Wed, 25 May 2011 21:22:30 +0000 (UTC) [thread overview]
Message-ID: <loom.20110525T231844-341@post.gmane.org> (raw)
In-Reply-To: 1AEF57D5-49E0-4F37-BE8D-DEBD25965D83@gernhardtsoftware.com
Brian Gernhardt <brian <at> gernhardtsoftware.com> writes:
>
> Some would be right. I tend to find that the BSD (and BSD-like) libraries on
OS X are more strict and have less
> features than the GNU equivalents. (The fact that OS X's libreadline is
actually the only mostly
> compatible libedit drives me batty sometimes.)
>
> This does leave us with the question of what to do with the test. Perhaps a
pattern like "a*+b" to match
> "aa+b"? Plain + should always match just + in a BRE, even if \+ is special,
and the * makes sure that it is a
> regex instead of plain string matching.
>
> ~~ Brian
>
>
You're right about \+ in BRE. I guess I missed that because glibc's
implementation isn't strict BRE. I'll post a patch that fixes this problem.
Thanks for catching this up!
prev parent reply other threads:[~2011-05-25 21:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 3:27 t7810.94 (git-grep -E -F -G) never passed Brian Gernhardt
2011-05-25 10:21 ` Michael J Gruber
2011-05-25 12:48 ` Brian Gernhardt
2011-05-25 21:22 ` Michał Kiedrowicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20110525T231844-341@post.gmane.org \
--to=michal.kiedrowicz@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).