* [PATCH/RFC] Restore line limit option in post-receive-email
@ 2011-11-11 6:35 Cheng Leong
2011-11-11 6:56 ` Junio C Hamano
0 siblings, 1 reply; 4+ messages in thread
From: Cheng Leong @ 2011-11-11 6:35 UTC (permalink / raw)
To: git; +Cc: kpfleming, Cheng Leong
The hooks.emailmaxlines config currently has no effect. Stop
prep_for_email from clobbering the already-initialized maxlines
variable in the contrib/hooks/post-receive-email example.
Signed-off-by: Cheng Leong <leongc@alumni.rice.edu>
---
contrib/hooks/post-receive-email | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index ba077c1..ac2e0ed 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -85,7 +85,6 @@ prep_for_email()
oldrev=$(git rev-parse $1)
newrev=$(git rev-parse $2)
refname="$3"
- maxlines=$4
# --- Interpret
# 0000->1234 (create)
--
1.7.7.1.msysgit.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] Restore line limit option in post-receive-email
2011-11-11 6:35 [PATCH/RFC] Restore line limit option in post-receive-email Cheng Leong
@ 2011-11-11 6:56 ` Junio C Hamano
2011-11-11 7:08 ` Cheng Leong
0 siblings, 1 reply; 4+ messages in thread
From: Junio C Hamano @ 2011-11-11 6:56 UTC (permalink / raw)
To: Cheng Leong; +Cc: git, kpfleming
Cheng Leong <leongc@alumni.rice.edu> writes:
> The hooks.emailmaxlines config currently has no effect. Stop
> prep_for_email from clobbering the already-initialized maxlines
> variable in the contrib/hooks/post-receive-email example.
>
> Signed-off-by: Cheng Leong <leongc@alumni.rice.edu>
> ---
> contrib/hooks/post-receive-email | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
> index ba077c1..ac2e0ed 100755
> --- a/contrib/hooks/post-receive-email
> +++ b/contrib/hooks/post-receive-email
> @@ -85,7 +85,6 @@ prep_for_email()
> oldrev=$(git rev-parse $1)
> newrev=$(git rev-parse $2)
> refname="$3"
> - maxlines=$4
>
> # --- Interpret
> # 0000->1234 (create)
Umm, there is another place where $maxlines is used without
merit. Shouldn't we do something like below as well?
contrib/hooks/post-receive-email | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email
index ba077c1..e27ca3c 100755
--- a/contrib/hooks/post-receive-email
+++ b/contrib/hooks/post-receive-email
@@ -743,6 +743,6 @@ else
while read oldrev newrev refname
do
prep_for_email $oldrev $newrev $refname || continue
- generate_email $maxlines | send_mail
+ generate_email | send_mail
done
fi
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH/RFC] Restore line limit option in post-receive-email
2011-11-11 6:56 ` Junio C Hamano
@ 2011-11-11 7:08 ` Cheng Leong
2012-01-12 21:01 ` Cheng Leong
0 siblings, 1 reply; 4+ messages in thread
From: Cheng Leong @ 2011-11-11 7:08 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, kpfleming
Junio C Hamano <gitster@pobox.com> wrote:
> Umm, there is another place where $maxlines is used without
> merit. Shouldn't we do something like below as well?
...
> - generate_email $maxlines | send_mail
> + generate_email | send_mail
Agree. $maxlines is harmless, but extraneous here.
Would you like me to reroll a patch with both or is this a trivial fixup?
Cheng
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-12 21:05 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-11 6:35 [PATCH/RFC] Restore line limit option in post-receive-email Cheng Leong
2011-11-11 6:56 ` Junio C Hamano
2011-11-11 7:08 ` Cheng Leong
2012-01-12 21:01 ` Cheng Leong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).