git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Ubuntu: gitweb always looks for projects in /var/cache/git (“404 - no projects found”)
@ 2012-11-29 13:55 Alfonso Muñoz-Pomer Fuentes
  2012-11-29 18:28 ` Jeff King
  0 siblings, 1 reply; 3+ messages in thread
From: Alfonso Muñoz-Pomer Fuentes @ 2012-11-29 13:55 UTC (permalink / raw)
  To: git

I’ve discovered this weird behaviour in gitweb and documented a workaround in
StackOverflow:
http://stackoverflow.com/questions/13609475/ubuntu-gitweb-always-looks-for-projects-in-var-cache-git-404-no-projects-f

Basically, the variable $projectroot in gitweb.cgi in the beginning is reset to
the system default value in git_get_projects_list, when it is declared again.

Is this a known bug? Or am I missing something?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Ubuntu: gitweb always looks for projects in /var/cache/git (“404 - no projects found”)
  2012-11-29 13:55 Ubuntu: gitweb always looks for projects in /var/cache/git (“404 - no projects found”) Alfonso Muñoz-Pomer Fuentes
@ 2012-11-29 18:28 ` Jeff King
  2012-12-03 17:10   ` Alfonso Muñoz-Pomer Fuentes
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff King @ 2012-11-29 18:28 UTC (permalink / raw)
  To: Alfonso Muñoz-Pomer Fuentes; +Cc: git

On Thu, Nov 29, 2012 at 01:55:57PM +0000, Alfonso Muñoz-Pomer Fuentes wrote:

> I’ve discovered this weird behaviour in gitweb and documented a workaround in
> StackOverflow:
> http://stackoverflow.com/questions/13609475/ubuntu-gitweb-always-looks-for-projects-in-var-cache-git-404-no-projects-f
> 
> Basically, the variable $projectroot in gitweb.cgi in the beginning is reset to
> the system default value in git_get_projects_list, when it is declared again.
> 
> Is this a known bug? Or am I missing something?

I think the analysis in that stack overflow post is wrong. The use of
"our" in git_get_projects_list is not the culprit.

The problem is that one should not edit gitweb.cgi directly; its
built-in defaults (which you are tweaking) are overridden by
/etc/gitweb.conf, which is shipped by the Ubuntu package. You should
be making your changes in the config file, not the CGI script.

-Peff

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Ubuntu: gitweb always looks for projects in /var/cache/git (“404 - no projects found”)
  2012-11-29 18:28 ` Jeff King
@ 2012-12-03 17:10   ` Alfonso Muñoz-Pomer Fuentes
  0 siblings, 0 replies; 3+ messages in thread
From: Alfonso Muñoz-Pomer Fuentes @ 2012-12-03 17:10 UTC (permalink / raw)
  Cc: git

Thank you very much for the clarification. Noticing how this wasn’t 
documented anywhere I had the feeling that I was missing something.

On Thu 29 Nov 2012 19:28:26 CET, Jeff King wrote:
> On Thu, Nov 29, 2012 at 01:55:57PM +0000, Alfonso Muñoz-Pomer Fuentes wrote:
>
>> I’ve discovered this weird behaviour in gitweb and documented a workaround in
>> StackOverflow:
>> http://stackoverflow.com/questions/13609475/ubuntu-gitweb-always-looks-for-projects-in-var-cache-git-404-no-projects-f
>>
>> Basically, the variable $projectroot in gitweb.cgi in the beginning is reset to
>> the system default value in git_get_projects_list, when it is declared again.
>>
>> Is this a known bug? Or am I missing something?
>
> I think the analysis in that stack overflow post is wrong. The use of
> "our" in git_get_projects_list is not the culprit.
>
> The problem is that one should not edit gitweb.cgi directly; its
> built-in defaults (which you are tweaking) are overridden by
> /etc/gitweb.conf, which is shipped by the Ubuntu package. You should
> be making your changes in the config file, not the CGI script.
>
> -Peff

--
Alfonso Muñoz-Pomer Fuentes
Johann Heinrich von Thünen-Institut
Bundesforschungsinstitut für Ländliche Räume, Wald und Fischerei
Institut für Forstgenetik
Sieker Landstrasse 2
22927 Grosshansdorf

Telefon: +49 (0)4102/696-145
Fax:     +49 (0)4102/696-200
Email:   alfonso.munozpomer@vti.bund.de
Web:     http://www.vti.bund.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-12-03 17:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-29 13:55 Ubuntu: gitweb always looks for projects in /var/cache/git (“404 - no projects found”) Alfonso Muñoz-Pomer Fuentes
2012-11-29 18:28 ` Jeff King
2012-12-03 17:10   ` Alfonso Muñoz-Pomer Fuentes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).