From: Marat Radchenko <marat@slonopotamus.org>
To: git@vger.kernel.org
Subject: Re: [PATCH] MSVC: added missing include so `makeINLINE=__inline` is no longer required
Date: Thu, 27 Mar 2014 17:43:40 +0000 (UTC) [thread overview]
Message-ID: <loom.20140327T183247-442@post.gmane.org> (raw)
In-Reply-To: xmqqzjkbegdt.fsf@gitster.dls.corp.google.com
Junio C Hamano <gitster <at> pobox.com> writes:
> My gut feeling is that adding a mechanism to add -DINLINE=__inline
> only on MSVC to the top-level Makefile, without touching this file,
> may be a much more palatable.
Okay, I'll think more about this one. Maybe *moving* inline=__inline from
compat-headers into Makefile (actually, config.mak.uname) will work better.
Hope it doesn't prevent first patch from being integrated -- joining them in a
single thread was unintentional misuse of `git send-email` flags.
next prev parent reply other threads:[~2014-03-27 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-27 7:34 [PATCH] MSVC: allow enabling CURL Marat Radchenko
2014-03-27 7:34 ` [PATCH] MSVC: added missing include so `make INLINE=__inline` is no longer required Marat Radchenko
2014-03-27 16:49 ` Junio C Hamano
2014-03-27 17:43 ` Marat Radchenko [this message]
2014-03-28 7:33 ` [PATCH v2] MSVC: define INLINE=__inline so simple `make MSVC=1` actually works Marat Radchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20140327T183247-442@post.gmane.org \
--to=marat@slonopotamus.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).