From: Sean Allred <allred.sean@gmail.com>
To: Vijay Raghavan Aravamudhan <avijayr@gmail.com>
Cc: Sean Allred <allred.sean@gmail.com>, git@vger.kernel.org
Subject: Re: git status became very slow after upgrading git
Date: Sat, 10 Feb 2024 13:06:29 -0600 [thread overview]
Message-ID: <m0o7co8688.fsf@epic96565.epic.com> (raw)
In-Reply-To: <CAK7MZG29+Cy-7SJnWayro_5GGEe3iZLysQqVaATLz8GLtEtA5A@mail.gmail.com>
Vijay Raghavan Aravamudhan <avijayr@gmail.com> writes:
> Thanks for responding. I have run the command that you gave on an open
> source repo so that its easy for you to replicate. The remote url is:
> https://github.com/vraravam/ferdium-app
>
> The output is:
>
> [[ I took the liberty of cleaning this up; ]]
> [[ let's hope formatting is preserved now. ]]
>
> ferdium-app.git:develop$ GIT_TRACE=1 GIT_TRACE_SETUP=1 GIT_TRACE_PERFORMANCE=1 git status
> 00:08:15.548976 trace.c:314 setup: git_dir: .git
> 00:08:15.550590 trace.c:315 setup: git_common_dir: .git
> 00:08:15.550600 trace.c:316 setup: worktree: /Users/vijay/dev/oss/ferdium
> 00:08:15.550604 trace.c:317 setup: cwd: /Users/vijay/dev/oss/ferdium
> 00:08:15.550611 trace.c:318 setup: prefix: (null)
> 00:08:15.550707 chdir-notify.c:70 setup: chdir from '/Users/vijay/dev/oss/ferdium' to '/Users/vijay/dev/oss/ferdium'
> 00:08:15.550723 git.c:463 trace: built-in: git status
> 00:08:15.552184 read-cache.c:2386 performance: 0.000183000 s: read cache .git/index
> 00:08:15.555964 read-cache.c:1629 performance: 0.003696000 s: refresh index
> 00:08:15.556442 diff-lib.c:273 performance: 0.000132000 s: diff-files
> 00:08:15.558558 unpack-trees.c:2004 performance: 0.000019000 s: traverse_trees
> 00:08:15.558801 unpack-trees.c:438 performance: 0.000003000 s: check_updates
> 00:08:15.558813 unpack-trees.c:2096 performance: 0.000394000 s: unpack_trees
> 00:08:15.558819 diff-lib.c:638 performance: 0.000524000 s: diff-index
> 00:08:15.559166 name-hash.c:613 performance: 0.000148000 s: initialize name hash
> On branch develop
> Your branch is up to date with 'origin/develop'.
>
> 00:08:15.567249 run-command.c:657 trace: run_command: GIT_INDEX_FILE=.git/index git submodule summary --cached --for-status --summary-limit -1 HEAD
> 00:08:15.833334 git.c:749 trace: exec: git-submodule summary --cached --for-status --summary-limit -1 HEAD
> 00:08:15.834114 run-command.c:657 trace: run_command: git-submodule summary --cached --for-status --summary-limit -1 HEAD
> 00:08:16.880778 trace.c:414 performance: 0.000013000 s: git command: git --exec-path
> 00:08:18.216639 git.c:463 trace: built-in: git rev-parse --git-dir
> 00:08:18.218740 trace.c:414 performance: 0.002132000 s: git command: git rev-parse --git-dir
> 00:08:18.489025 git.c:463 trace: built-in: git rev-parse --git-path objects
> 00:08:18.490677 trace.c:414 performance: 0.001675000 s: git command: git rev-parse --git-path objects
> 00:08:19.031080 git.c:463 trace: built-in: git rev-parse --show-prefix
> 00:08:19.032882 trace.c:414 performance: 0.001827000 s: git command: git rev-parse --show-prefix
> 00:08:19.296074 git.c:463 trace: built-in: git rev-parse --show-toplevel
> 00:08:19.297559 trace.c:414 performance: 0.001504000 s: git command: git rev-parse --show-toplevel
> 00:08:19.830285 trace.c:314 setup: git_dir: .git
> 00:08:19.830972 trace.c:315 setup: git_common_dir: .git
> 00:08:19.830981 trace.c:316 setup: worktree: /Users/vijay/dev/oss/ferdium
> 00:08:19.830984 trace.c:317 setup: cwd: /Users/vijay/dev/oss/ferdium
> 00:08:19.830990 trace.c:318 setup: prefix: (null)
> 00:08:19.830994 git.c:463 trace: built-in: git submodule--helper summary --cached --for-status -n -1 -- HEAD
> 00:08:19.834629 read-cache.c:2386 performance: 0.000164000 s: read cache .git/index
> 00:08:19.834914 unpack-trees.c:2004 performance: 0.000024000 s: traverse_trees
> 00:08:19.834932 unpack-trees.c:438 performance: 0.000003000 s: check_updates
> 00:08:19.834940 unpack-trees.c:2096 performance: 0.000157000 s: unpack_trees
> 00:08:19.834958 diff-lib.c:638 performance: 0.000307000 s: diff-index
> 00:08:19.834975 trace.c:414 performance: 0.005922000 s: git command: git submodule--helper summary --cached --for-status -n -1 -- HEAD
> 00:08:19.836137 trace.c:414 performance: 4.003693000 s: git command: /opt/homebrew/opt/git/libexec/git-core/git submodule summary --cached --for-status --summary-limit -1 HEAD
> 00:08:19.836842 run-command.c:657 trace: run_command: GIT_INDEX_FILE=.git/index git submodule summary --files --for-status --summary-limit -1
> 00:08:20.106802 git.c:749 trace: exec: git-submodule summary --files --for-status --summary-limit -1
> 00:08:20.107638 run-command.c:657 trace: run_command: git-submodule summary --files --for-status --summary-limit -1
> 00:08:21.162243 trace.c:414 performance: 0.000006000 s: git command: git --exec-path
> 00:08:22.496146 git.c:463 trace: built-in: git rev-parse --git-dir
> 00:08:22.497722 trace.c:414 performance: 0.001589000 s: git command: git rev-parse --git-dir
> 00:08:22.764795 git.c:463 trace: built-in: git rev-parse --git-path objects
> 00:08:22.766763 trace.c:414 performance: 0.001991000 s: git command: git rev-parse --git-path objects
> 00:08:23.304626 git.c:463 trace: built-in: git rev-parse --show-prefix
> 00:08:23.306436 trace.c:414 performance: 0.001833000 s: git command: git rev-parse --show-prefix
> 00:08:23.575506 git.c:463 trace: built-in: git rev-parse --show-toplevel
> 00:08:23.577138 trace.c:414 performance: 0.001656000 s: git command: git rev-parse --show-toplevel
> 00:08:24.111335 trace.c:314 setup: git_dir: .git
> 00:08:24.112123 trace.c:315 setup: git_common_dir: .git
> 00:08:24.112138 trace.c:316 setup: worktree: /Users/vijay/dev/oss/ferdium
> 00:08:24.112142 trace.c:317 setup: cwd: /Users/vijay/dev/oss/ferdium
> 00:08:24.112149 trace.c:318 setup: prefix: (null)
> 00:08:24.112154 git.c:463 trace: built-in: git submodule--helper summary --files --for-status -n -1 --
> 00:08:24.113679 read-cache.c:2386 performance: 0.000216000 s: read cache .git/index
> 00:08:24.117811 diff-lib.c:273 performance: 0.004115000 s: diff-files
> 00:08:24.117838 trace.c:414 performance: 0.007389000 s: git command: git submodule--helper summary --files --for-status -n -1 --
> 00:08:24.118895 trace.c:414 performance: 4.013083000 s: git command: /opt/homebrew/opt/git/libexec/git-core/git submodule summary --files --for-status --summary-limit -1
> nothing to commit, working tree clean
> 00:08:24.119646 trace.c:414 performance: 8.571954000 s: git command: git status
>
> Hope this helps. Also, I noticed that the same repo, same versions of
> all tools, etc - this issue only occurs on my M2 mac, but works
> without any slowness on the intel mac.
Thanks, that info does help. It at least narrows it down to these two
subprocesses:
git submodule--helper summary --cached --for-status -n -1 -- HEAD
git submodule--helper summary --files --for-status -n -1 --
Unfortunately, I'm still not able to reproduce on my M2 (even with that
config set globally), so I wonder if there's something else at play.
I've probably reached the end of my usefulness (since the problem does
appear to be specific to submodules and cmd_submodule__helper seems to
be lacking documentation), but you might consider replying with your
output of
git config --list --show-scope
after stripping any private information, of course.
I'll provide my info down below in the hopes that it's useful for
comparison by someone who knows more about this subsystem. It's worth
noting that I'm running the same submodule--helper command and it's
completing in a reasonable timeframe for me.
Configuration:
ferdium-app.git:develop$ git --no-pager config --list --show-scope
system credential.helper=osxkeychain
system filter.lfs.clean=git-lfs clean -- %f
system filter.lfs.smudge=git-lfs smudge -- %f
system filter.lfs.process=git-lfs filter-process
system filter.lfs.required=true
global user.signingkey=/Users/sallred/.ssh/id_ed25519.pub
global pull.rebase=true
global push.default=current
global core.editor=mg
global core.excludesfile=/Users/sallred/.gitignore
global core.fsmonitor=true
global core.whitespace=trailing-space
global init.defaultbranch=main
global remote.pushdefault=origin
global branch.autosetupmerge=true
global rerere.enabled=true
global gpg.format=ssh
global maintenance.repo=/Users/sallred/a
global maintenance.repo=/Users/sallred/b
global maintenance.repo=/Users/sallred/c
global maintenance.repo=/Users/sallred/d
global commit.gpgsign=true
global diff.wserrorhighlight=old,new
global gpg.ssh.allowedsignersfile=/Users/sallred/.ssh/allowed_signers
global remote.origin.fetch=+refs/notes/*:refs/notes/*
global status.submodulesummary=true
local core.repositoryformatversion=0
local core.filemode=true
local core.bare=false
local core.logallrefupdates=true
local core.ignorecase=true
local core.precomposeunicode=true
local remote.origin.url=git@github.com:vraravam/ferdium-app
local remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
local branch.develop.remote=origin
local branch.develop.merge=refs/heads/develop
Performance data:
ferdium-app.git:develop$ GIT_TRACE=1 GIT_TRACE_SETUP=1 GIT_TRACE_PERFORMANCE=1 git status
13:29:32.879597 trace.c:314 setup: git_dir: .git
13:29:32.880020 trace.c:315 setup: git_common_dir: .git
13:29:32.880026 trace.c:316 setup: worktree: /Users/sallred/tmp/ferdium-app
13:29:32.880029 trace.c:317 setup: cwd: /Users/sallred/tmp/ferdium-app
13:29:32.880033 trace.c:318 setup: prefix: (null)
13:29:32.880071 chdir-notify.c:70 setup: chdir from '/Users/sallred/tmp/ferdium-app' to '/Users/sallred/tmp/ferdium-app'
13:29:32.880078 git.c:463 trace: built-in: git status
13:29:32.880606 read-cache.c:2386 performance: 0.000118000 s: read cache .git/index
13:29:32.904888 read-cache.c:1629 performance: 0.000082000 s: refresh index
13:29:32.905983 diff-lib.c:273 performance: 0.000287000 s: diff-files
13:29:32.907393 unpack-trees.c:2004 performance: 0.000014000 s: traverse_trees
13:29:32.907403 unpack-trees.c:438 performance: 0.000002000 s: check_updates
13:29:32.907407 unpack-trees.c:2096 performance: 0.000109000 s: unpack_trees
13:29:32.907410 diff-lib.c:638 performance: 0.000163000 s: diff-index
13:29:32.907681 name-hash.c:613 performance: 0.000107000 s: initialize name hash
13:29:32.922245 run-command.c:657 trace: run_command: GIT_INDEX_FILE=.git/index git submodule summary --cached --for-status --summary-limit -1 HEAD
On branch develop
Your branch is up to date with 'origin/develop'.
13:29:32.928117 git.c:749 trace: exec: git-submodule summary --cached --for-status --summary-limit -1 HEAD
13:29:32.928715 run-command.c:657 trace: run_command: git-submodule summary --cached --for-status --summary-limit -1 HEAD
13:29:32.941067 trace.c:414 performance: 0.000002000 s: git command: git --exec-path
13:29:32.961582 git.c:463 trace: built-in: git rev-parse --git-dir
13:29:32.962376 trace.c:414 performance: 0.000802000 s: git command: git rev-parse --git-dir
13:29:32.966772 git.c:463 trace: built-in: git rev-parse --git-path objects
13:29:32.967437 trace.c:414 performance: 0.000673000 s: git command: git rev-parse --git-path objects
13:29:32.976243 git.c:463 trace: built-in: git rev-parse --show-prefix
13:29:32.976902 trace.c:414 performance: 0.000667000 s: git command: git rev-parse --show-prefix
13:29:32.981157 git.c:463 trace: built-in: git rev-parse --show-toplevel
13:29:32.981835 trace.c:414 performance: 0.000690000 s: git command: git rev-parse --show-toplevel
13:29:32.989790 trace.c:314 setup: git_dir: .git
13:29:32.990234 trace.c:315 setup: git_common_dir: .git
13:29:32.990238 trace.c:316 setup: worktree: /Users/sallred/tmp/ferdium-app
13:29:32.990242 trace.c:317 setup: cwd: /Users/sallred/tmp/ferdium-app
13:29:32.990245 trace.c:318 setup: prefix: (null)
13:29:32.990246 git.c:463 trace: built-in: git submodule--helper summary --cached --for-status -n -1 -- HEAD
13:29:32.991301 read-cache.c:2386 performance: 0.000062000 s: read cache .git/index
13:29:33.002570 unpack-trees.c:2004 performance: 0.000009000 s: traverse_trees
13:29:33.002577 unpack-trees.c:438 performance: 0.000001000 s: check_updates
13:29:33.002580 unpack-trees.c:2096 performance: 0.000074000 s: unpack_trees
13:29:33.002585 diff-lib.c:638 performance: 0.000117000 s: diff-index
13:29:33.002591 trace.c:414 performance: 0.013037000 s: git command: git submodule--helper summary --cached --for-status -n -1 -- HEAD
13:29:33.003099 trace.c:414 performance: 0.075293000 s: git command: /opt/homebrew/opt/git/libexec/git-core/git submodule summary --cached --for-status --summary-limit -1 HEAD
13:29:33.003446 run-command.c:657 trace: run_command: GIT_INDEX_FILE=.git/index git submodule summary --files --for-status --summary-limit -1
13:29:33.007530 git.c:749 trace: exec: git-submodule summary --files --for-status --summary-limit -1
13:29:33.007926 run-command.c:657 trace: run_command: git-submodule summary --files --for-status --summary-limit -1
13:29:33.017316 trace.c:414 performance: 0.000002000 s: git command: git --exec-path
13:29:33.036544 git.c:463 trace: built-in: git rev-parse --git-dir
13:29:33.037494 trace.c:414 performance: 0.000959000 s: git command: git rev-parse --git-dir
13:29:33.041936 git.c:463 trace: built-in: git rev-parse --git-path objects
13:29:33.042731 trace.c:414 performance: 0.000803000 s: git command: git rev-parse --git-path objects
13:29:33.051651 git.c:463 trace: built-in: git rev-parse --show-prefix
13:29:33.052320 trace.c:414 performance: 0.000678000 s: git command: git rev-parse --show-prefix
13:29:33.056260 git.c:463 trace: built-in: git rev-parse --show-toplevel
13:29:33.057043 trace.c:414 performance: 0.000793000 s: git command: git rev-parse --show-toplevel
13:29:33.064488 trace.c:314 setup: git_dir: .git
13:29:33.064860 trace.c:315 setup: git_common_dir: .git
13:29:33.064862 trace.c:316 setup: worktree: /Users/sallred/tmp/ferdium-app
13:29:33.064863 trace.c:317 setup: cwd: /Users/sallred/tmp/ferdium-app
13:29:33.064866 trace.c:318 setup: prefix: (null)
13:29:33.064867 git.c:463 trace: built-in: git submodule--helper summary --files --for-status -n -1 --
13:29:33.065421 read-cache.c:2386 performance: 0.000085000 s: read cache .git/index
13:29:33.079310 diff-lib.c:273 performance: 0.000026000 s: diff-files
13:29:33.079330 trace.c:414 performance: 0.015094000 s: git command: git submodule--helper summary --files --for-status -n -1 --
13:29:33.079947 trace.c:414 performance: 0.072649000 s: git command: /opt/homebrew/opt/git/libexec/git-core/git submodule summary --files --for-status --summary-limit -1
13:29:33.080290 trace.c:414 performance: 0.201218000 s: git command: git status
nothing to commit, working tree clean
--
Sean Allred
next prev parent reply other threads:[~2024-02-10 19:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-10 4:49 git status became very slow after upgrading git Vijay Raghavan Aravamudhan
2024-02-10 17:06 ` Sean Allred
2024-02-10 18:42 ` Vijay Raghavan Aravamudhan
2024-02-10 19:06 ` Sean Allred [this message]
2024-02-10 19:57 ` Vijay Raghavan Aravamudhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m0o7co8688.fsf@epic96565.epic.com \
--to=allred.sean@gmail.com \
--cc=avijayr@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox