Git development
 help / color / mirror / Atom feed
From: Sean Allred <allred.sean@gmail.com>
To: Maarten Ackermans <maarten.ackermans@gmail.com>
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>, git@vger.kernel.org
Subject: Re: Breaking change with "git log -n" since 2.43
Date: Wed, 21 Feb 2024 09:34:28 -0600	[thread overview]
Message-ID: <m0v86hbze6.fsf@epic96565.epic.com> (raw)
In-Reply-To: <CAB=tB2vKj45yr3amMbhv_dYBdqYOtoiMS7Ecx4WO1TE2STHEsA@mail.gmail.com>


Maarten Ackermans <maarten.ackermans@gmail.com> writes:

> I think you’re right, so reinstating the original behavior with a
> deprecation warning would be more prudent.
>
> After the grace period, if invalid input is given, fall back to output
> all with a warning. Or you can go the strict route again and crash
> with a fatal error (hard to imagine an actual use case for such a
> large, specific number, anyway).

To be clear, I'm not advocating we go back to the prior behavior. I'm
just clarifying what your proposal would mean.

I don't pretend to have any nuanced understanding of how the Git project
handles situations like this, but IMHO, I would have to fall back to the
principle of least surprise. Rejecting invalid input is not a crash --
it is a useful guardrail to ensure the user and the computer agree on
what's been requested / what's going to happen.

Again, I don't have any experience with how similar situations are
handled here, but I would contend that the behavior you describe as the
breaking behavior is the behavior that should exist long-term.

--
Sean Allred

  parent reply	other threads:[~2024-02-21 15:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21 13:32 Breaking change with "git log -n" since 2.43 Maarten Ackermans
2024-02-21 13:55 ` Kristoffer Haugsbakk
2024-02-21 14:21   ` Maarten Ackermans
2024-02-21 14:24     ` Sean Allred
2024-02-21 15:07       ` Maarten Ackermans
2024-02-21 15:17         ` Sean Allred
     [not found]           ` <CAB=tB2vKj45yr3amMbhv_dYBdqYOtoiMS7Ecx4WO1TE2STHEsA@mail.gmail.com>
2024-02-21 15:34             ` Sean Allred [this message]
2024-02-21 15:32         ` Kristoffer Haugsbakk
2024-02-21 15:38     ` Kristoffer Haugsbakk
2024-02-21 17:51 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m0v86hbze6.fsf@epic96565.epic.com \
    --to=allred.sean@gmail.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=maarten.ackermans@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox