Git development
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: [PATCH] Fix git-format-patch -s to include a Signed-off-by: line...
Date: Wed, 25 Jan 2006 13:03:41 -0700	[thread overview]
Message-ID: <m1r76why76.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <7voe212h53.fsf@assigned-by-dhcp.cox.net> (Junio C. Hamano's message of "Tue, 24 Jan 2006 18:08:56 -0800")


In the last round of bug fixes the signed-off-by line was still be
generated but it was not including a signed-off-by line :(

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>


---

 git-format-patch.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

78308e7078be1beb979def50579722910f2ff54f
diff --git a/git-format-patch.sh b/git-format-patch.sh
index 7e67c4e..5fb8ce1 100755
--- a/git-format-patch.sh
+++ b/git-format-patch.sh
@@ -178,7 +178,7 @@ my ($signoff_pattern, $done_header, $don
     $last_was_signoff);
 
 if ($signoff) {
-	$signoff = `git-var GIT_COMMITTER_IDENT`;
+	$signoff = "Signed-off-by: " . `git-var GIT_COMMITTER_IDENT`;
 	$signoff =~ s/>.*/>/;
 	$signoff_pattern = quotemeta($signoff);
 }
-- 
1.1.4.g7830

      reply	other threads:[~2006-01-25 20:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-25  2:08 [PATCH 2/2] diff-tree --cc: denser combined diff output for a merge commit Junio C Hamano
2006-01-25 20:03 ` Eric W. Biederman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1r76why76.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox