From: Andreas Schwab <schwab@linux-m68k.org>
To: Tay Ray Chuan <rctay89@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
Jay Soffian <jaysoffian@gmail.com>,
Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
Miles Bader <miles@gnu.org>
Subject: Re: [PATCH v2] smart-http: Don't change POST to GET when following redirect
Date: Fri, 24 Sep 2010 20:06:35 +0200 [thread overview]
Message-ID: <m21v8jaudw.fsf@igel.home> (raw)
In-Reply-To: <1285309223-4348-1-git-send-email-rctay89@gmail.com> (Tay Ray Chuan's message of "Fri, 24 Sep 2010 14:20:23 +0800")
Tay Ray Chuan <rctay89@gmail.com> writes:
> diff --git a/http.c b/http.c
> index 1320c50..25f8b45 100644
> --- a/http.c
> +++ b/http.c
> @@ -275,6 +275,9 @@ static CURL *get_curl_handle(void)
> }
>
> curl_easy_setopt(result, CURLOPT_FOLLOWLOCATION, 1);
> +#if LIBCURL_VERSION_NUM >= 0x071301
> + curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL);
> +#endif
Should this fall back to CURLOPT_POST301 on older versions? (Those
won't handle 302 though, I think.)
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-09-24 18:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-18 4:33 git "smart http" server vs. http redirects Miles Bader
2010-09-18 7:03 ` Ilari Liusvaara
2010-09-18 8:16 ` Andreas Schwab
2010-09-18 8:47 ` [PATCH] smart-http: Don't change POST to GET when following redirect Andreas Schwab
2010-09-18 14:09 ` Miles Bader
2010-09-18 21:00 ` Jay Soffian
2010-09-24 6:20 ` [PATCH v2] " Tay Ray Chuan
2010-09-24 18:06 ` Andreas Schwab [this message]
2010-09-25 4:20 ` [PATCH v3] " Tay Ray Chuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m21v8jaudw.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=jaysoffian@gmail.com \
--cc=miles@gnu.org \
--cc=rctay89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).