From: Andreas Schwab <schwab@linux-m68k.org>
To: Jeff King <peff@peff.net>
Cc: Michael Haggerty <mhagger@alum.mit.edu>,
Junio C Hamano <gitster@pobox.com>,
git discussion list <git@vger.kernel.org>,
Michal Rokos <michal.rokos@nextsoft.cz>,
Brandon Casey <casey@nrlssc.navy.mil>
Subject: Re: Breakage (?) in configure and git_vsnprintf()
Date: Mon, 12 Dec 2011 10:30:27 +0100 [thread overview]
Message-ID: <m262hmgmrw.fsf@igel.home> (raw)
In-Reply-To: <20111212064305.GA16511@sigill.intra.peff.net> (Jeff King's message of "Mon, 12 Dec 2011 01:43:05 -0500")
Jeff King <peff@peff.net> writes:
> if (maxsize > 0) {
> - ret = vsnprintf(str, maxsize-SNPRINTF_SIZE_CORR, format, ap);
> + va_copy(cp, ap);
> + ret = vsnprintf(str, maxsize-SNPRINTF_SIZE_CORR, format, cp);
You also need to call va_end on the copy.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-12-12 9:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-11 18:42 Breakage (?) in configure and git_vsnprintf() Michael Haggerty
2011-12-12 6:43 ` Jeff King
2011-12-12 7:45 ` Johannes Sixt
2011-12-12 8:10 ` Jeff King
2011-12-12 8:23 ` Junio C Hamano
2011-12-12 9:30 ` Andreas Schwab [this message]
2011-12-12 14:25 ` Jeff King
2011-12-12 23:25 ` Brandon Casey
2011-12-12 10:25 ` Michael Haggerty
2011-12-12 21:56 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m262hmgmrw.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mhagger@alum.mit.edu \
--cc=michal.rokos@nextsoft.cz \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).