* [PATCH] Don't cut off last character of commit descriptions.
@ 2008-06-30 10:08 Nikolaj Schumacher
2008-06-30 10:55 ` David Kågedal
0 siblings, 1 reply; 3+ messages in thread
From: Nikolaj Schumacher @ 2008-06-30 10:08 UTC (permalink / raw)
To: git; +Cc: David Kågedal
>From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
From: Nikolaj Schumacher <git@nschum.de>
Date: Mon, 30 Jun 2008 12:06:01 +0200
Subject: [PATCH] Don't cut off last character of commit descriptions.
---
contrib/emacs/git-blame.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index 9f92cd2..4fa70c5 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -381,7 +381,7 @@ See also function `git-blame-mode'."
"log" "-1"
(concat "--pretty=" git-blame-log-oneline-format)
hash)
- (buffer-substring (point-min) (1- (point-max)))))
+ (buffer-substring (point-min) (point-max))))
(defvar git-blame-last-identification nil)
(make-variable-buffer-local 'git-blame-last-identification)
--
1.5.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Don't cut off last character of commit descriptions.
2008-06-30 10:08 [PATCH] Don't cut off last character of commit descriptions Nikolaj Schumacher
@ 2008-06-30 10:55 ` David Kågedal
2008-07-16 21:11 ` Junio C Hamano
0 siblings, 1 reply; 3+ messages in thread
From: David Kågedal @ 2008-06-30 10:55 UTC (permalink / raw)
To: git, Nikolaj Schumacher
Nikolaj Schumacher <n_schumacher@web.de> writes:
> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
> From: Nikolaj Schumacher <git@nschum.de>
> Date: Mon, 30 Jun 2008 12:06:01 +0200
> Subject: [PATCH] Don't cut off last character of commit descriptions.
>
> ---
> contrib/emacs/git-blame.el | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
> index 9f92cd2..4fa70c5 100644
> --- a/contrib/emacs/git-blame.el
> +++ b/contrib/emacs/git-blame.el
> @@ -381,7 +381,7 @@ See also function `git-blame-mode'."
> "log" "-1"
> (concat "--pretty=" git-blame-log-oneline-format)
> hash)
> - (buffer-substring (point-min) (1- (point-max)))))
> + (buffer-substring (point-min) (point-max))))
>
> (defvar git-blame-last-identification nil)
> (make-variable-buffer-local 'git-blame-last-identification)
Yes, this should have been part of
24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when,
who and what in the minibuffer. that changed from using
--pretty=oneline to --pretty=format:... without terminating newline.
--
David Kågedal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Don't cut off last character of commit descriptions.
2008-06-30 10:55 ` David Kågedal
@ 2008-07-16 21:11 ` Junio C Hamano
0 siblings, 0 replies; 3+ messages in thread
From: Junio C Hamano @ 2008-07-16 21:11 UTC (permalink / raw)
To: David Kågedal; +Cc: git, Nikolaj Schumacher
David Kågedal <davidk@lysator.liu.se> writes:
> Nikolaj Schumacher <n_schumacher@web.de> writes:
>
>> From d485d9c86cba49671b74c7c1571a6ad7ec6d09b6 Mon Sep 17 00:00:00 2001
>> From: Nikolaj Schumacher <git@nschum.de>
>> Date: Mon, 30 Jun 2008 12:06:01 +0200
>> Subject: [PATCH] Don't cut off last character of commit descriptions.
>>
>> ---
>> contrib/emacs/git-blame.el | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
>> index 9f92cd2..4fa70c5 100644
>> --- a/contrib/emacs/git-blame.el
>> +++ b/contrib/emacs/git-blame.el
>> @@ -381,7 +381,7 @@ See also function `git-blame-mode'."
>> "log" "-1"
>> (concat "--pretty=" git-blame-log-oneline-format)
>> hash)
>> - (buffer-substring (point-min) (1- (point-max)))))
>> + (buffer-substring (point-min) (point-max))))
>>
>> (defvar git-blame-last-identification nil)
>> (make-variable-buffer-local 'git-blame-last-identification)
>
> Yes, this should have been part of
> 24a2293ad35d567530048f0d2b0d11e0012af26d git-blame.el: show the when,
> who and what in the minibuffer. that changed from using
> --pretty=oneline to --pretty=format:... without terminating newline.
Sorry, I realize I haven't applied the patch from Nikolaj. Should I take
this as an Ack?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-07-16 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-30 10:08 [PATCH] Don't cut off last character of commit descriptions Nikolaj Schumacher
2008-06-30 10:55 ` David Kågedal
2008-07-16 21:11 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).