From: Andreas Schwab <schwab@linux-m68k.org>
To: Sylvain Rabot <sylvain@abstraction.fr>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] git-mergetool--lib.sh: fix mergetool.<tool>.* configurations ignored for known tools
Date: Sat, 05 Jun 2010 11:11:54 +0200 [thread overview]
Message-ID: <m2fx11n8rp.fsf@igel.home> (raw)
In-Reply-To: <1275705112-8088-2-git-send-email-sylvain@abstraction.fr> (Sylvain Rabot's message of "Sat, 5 Jun 2010 04:31:52 +0200")
Sylvain Rabot <sylvain@abstraction.fr> writes:
> + if !test -f "$merge_tool_path/$merge_tool_cmd_base"; then
Missing space after '!'.
> + elif !test -x "$merge_tool_path/$merge_tool_cmd_base"; then
Likewise.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2010-06-05 9:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-05 2:31 [PATCH] git-mergetool--lib.sh: fix mergetool.<tool>.* configurations ignored for known tools Sylvain Rabot
2010-06-05 2:31 ` Sylvain Rabot
2010-06-05 9:11 ` Andreas Schwab [this message]
2010-06-05 22:42 ` Sylvain Rabot
2010-06-08 8:34 ` David Aguilar
2010-06-08 21:05 ` Junio C Hamano
2010-06-11 9:54 ` Sylvain Rabot
2010-06-09 19:24 ` Charles Bailey
2010-06-11 10:06 ` Sylvain Rabot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2fx11n8rp.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sylvain@abstraction.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).