From: Andreas Schwab <schwab@linux-m68k.org>
To: Drew Northup <n1xim.email@gmail.com>
Cc: glpk xypron <xypron.glpk@gmx.de>,
git@vger.kernel.org, jnareb@gmail.com,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [BUG] gitweb: XSS vulnerability of RSS feed
Date: Tue, 13 Nov 2012 00:09:05 +0100 [thread overview]
Message-ID: <m2ip9apgfi.fsf@igel.home> (raw)
In-Reply-To: <CAM9Z-n=6xsC7yiKJ+NU-CxNPxEXWmJzvXLUocgZgWPQnuK6G4Q@mail.gmail.com> (Drew Northup's message of "Mon, 12 Nov 2012 13:55:46 -0500")
Drew Northup <n1xim.email@gmail.com> writes:
> Something like this may be useful to defuse the "file" parameter, but
> I presume a more definitive fix is in order...
A proper fix will have to add esc_html to the feed generation, something
like this (untested):
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 10ed9e5..a51a8ba 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -8055,6 +8055,7 @@ sub git_feed {
$feed_type = 'history';
}
$title .= " $feed_type";
+ $title = esc_html($title);
my $descr = git_get_project_description($project);
if (defined $descr) {
$descr = esc_html($descr);
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-11-12 23:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-11 23:28 [BUG] gitweb: XSS vulnerability of RSS feed glpk xypron
2012-11-12 18:55 ` Drew Northup
2012-11-12 20:24 ` Jeff King
2012-11-12 20:27 ` Jeff King
2012-11-12 20:36 ` Junio C Hamano
2012-11-12 21:13 ` Jakub Narębski
2012-11-12 21:34 ` Jeff King
2012-11-13 14:44 ` Drew Northup
2012-11-13 15:19 ` Jakub Narębski
2012-11-13 15:45 ` Kevin
2012-11-13 15:57 ` Jakub Narębski
2012-11-13 17:04 ` Jeff King
2012-11-13 17:22 ` Jakub Narębski
2012-11-12 23:09 ` Andreas Schwab [this message]
2012-11-13 8:31 ` Pyeron, Jason J CTR (US)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2ip9apgfi.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=n1xim.email@gmail.com \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).