From: Seth Falcon <sethfalcon@gmail.com>
To: git@vger.kernel.org
Subject: gitk broken or user error?
Date: Sun, 12 Nov 2006 09:00:16 -0800 [thread overview]
Message-ID: <m2irhkr467.fsf@ziti.local> (raw)
Hi,
I get the following error when invoking gitk with any command line
argument, for example, 'gitk --all':
ziti:~/proj/R-devel seth$ gitk --all
Error in startup script: unknown option "-state"
while executing
".bar.view entryconf 3 -state normal"
invoked from within
"if {$cmdline_files ne {} || $revtreeargs ne {}} {
# create a view for the files/dirs specified on the command line
set curview 1
set selec..."
(file "/Users/seth/scm/bin/gitk" line 6298)
I tried a certainly incorrect thing; just commenting out the offending
lines:
diff --git a/gitk b/gitk
index ab383b3..a6c0a9f 100755
--- a/gitk
+++ b/gitk
@@ -6305,8 +6305,8 @@ if {$cmdline_files ne {} || $revtreeargs
set viewargs(1) $revtreeargs
set viewperm(1) 0
addviewmenu 1
- .bar.view entryconf 2 -state normal
- .bar.view entryconf 3 -state normal
+# .bar.view entryconf 2 -state normal
+# .bar.view entryconf 3 -state normal
}
if {[info exists permviews]} {
And now gitk _seems_ to work. No error message, and I can pass
argument to gitk like --all (wow, very useful).
I posted about this in October [*1*], but didn't get any response.
I'd like to be able to use gitk without my must-be-wrong patch. This
is on OS X ppc (git version 1.4.4.rc1.g73347) with Tcl & Tk at 8.4.7.
Can I provide more info? Have I missed a configuration step?
Thanks,
+ seth
next reply other threads:[~2006-11-12 17:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-12 17:00 Seth Falcon [this message]
2006-11-13 5:20 ` gitk broken or user error? Shawn Pearce
2006-11-13 22:05 ` Paul Mackerras
2006-11-13 22:28 ` Seth Falcon
2006-11-13 22:38 ` Seth Falcon
2006-11-13 22:42 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2irhkr467.fsf@ziti.local \
--to=sethfalcon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox