git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
	Jonathan Nieder <jrnieder@gmail.com>,
	Ilari Liusvaara <ilari.liusvaara@elisanet.fi>,
	Daniel Barkalow <barkalow@iabervon.org>,
	Gabriel Filion <lelutin@gmail.com>,
	Michael J Gruber <git@drmicha.warpmail.net>,
	Git Mailing List <git@vger.kernel.org>
Subject: Re: Re*: [PATCH v9] Documentation/remote-helpers: Add invocation  section
Date: Sat, 10 Apr 2010 18:06:58 +0530	[thread overview]
Message-ID: <m2jf3271551004100536q65725be3i224c7e7fb334563@mail.gmail.com> (raw)
In-Reply-To: <7vfx3567e2.fsf_-_@alter.siamese.dyndns.org>

Hi,

I like the idea, but I think it's too verbose. Perhaps something along
these lines?

1. In general, base your patches on 'master'.
2. If your patch is a bugfix try to base it on 'maint'. If the bug's
in 'master, but not in 'maint' also, base it on 'master'.
3. If you're working on a feature, some of whose patches are already
in 'pu', base your work on the tip of the last commit in your topic
branch (See THIS). If it's a minor correction, you might want to add a
note asking the maintainer to squash it into the previous commit.
4. If you're working on an elaborate feature that depends on many
commits in 'pu', maintain a public branch based on 'pu', and
periodically post patches to the mailing list for feedback (all based
on 'pu'). You might have to rebase/ wait before it's finally merged.

THIS:
> +   work on the tip of the topic.  "log --first-parent master..pu" would be
> +   a good way to find the tips of topic branches.

+ "The grandparent of this merge commit is your latest commit in this
topic. This is the commit you should base your patch on."

-- Ram

      parent reply	other threads:[~2010-04-10 12:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-07  5:57 [PATCH v9] Documentation/remote-helpers: Add invocation section Ramkumar Ramachandra
2010-04-07  8:56 ` Ramkumar Ramachandra
2010-04-07 15:05 ` Junio C Hamano
2010-04-07 16:50   ` Ramkumar Ramachandra
2010-04-07 17:23     ` Junio C Hamano
2010-04-07 17:58       ` Ramkumar Ramachandra
2010-04-07 22:49     ` Jonathan Nieder
2010-04-07 23:02       ` Junio C Hamano
2010-04-08  4:54         ` Ramkumar Ramachandra
2010-04-08  5:03           ` Jonathan Nieder
2010-04-08  5:14           ` Junio C Hamano
2010-04-10 12:24             ` Ramkumar Ramachandra
2010-04-08 18:52         ` Sverre Rabbelier
2010-04-08 20:01           ` Re*: " Junio C Hamano
2010-04-08 20:21             ` Sverre Rabbelier
2010-04-08 20:45               ` Junio C Hamano
2010-04-09  2:06             ` Michael J Gruber
2010-04-10  4:59               ` Junio C Hamano
2010-04-10 12:36             ` Ramkumar Ramachandra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2jf3271551004100536q65725be3i224c7e7fb334563@mail.gmail.com \
    --to=artagnon@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=ilari.liusvaara@elisanet.fi \
    --cc=jrnieder@gmail.com \
    --cc=lelutin@gmail.com \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).