From: Andreas Schwab <schwab@linux-m68k.org>
To: Mike Hommey <mh@glandium.org>
Cc: Jeff King <peff@peff.net>, Matthieu Moy <Matthieu.Moy@imag.fr>,
git@vger.kernel.org, Karl Chen <quarl@quarl.org>
Subject: Re: [PATCH] Expand ~ and ~user in core.excludesfile, commit.template
Date: Tue, 17 Nov 2009 22:20:39 +0100 [thread overview]
Message-ID: <m2lji43l20.fsf@igel.home> (raw)
In-Reply-To: <20091117074930.GB11636@glandium.org> (Mike Hommey's message of "Tue, 17 Nov 2009 08:49:30 +0100")
Mike Hommey <mh@glandium.org> writes:
> On Tue, Nov 17, 2009 at 02:34:26AM -0500, Jeff King wrote:
>> Maybe:
>>
>> A leading path component of "~user" is expanded to the home directory
>> of "user"; "~" is expanded to the home directory of the user running
>> git.
>>
>> would be more clear?
>
> Add "real" before "user running git" and you have my vote. Or maybe
> using the effective user would be better, and the patch should use
> geteuid() instead of getuid(), I don't know. ident.c uses getuid(), but
> I'm wondering if that's what it should use (although it doesn't seem to
> have been a problem to anyone)
"~" should just expand to the value of $HOME, like in the shell,
independent of the real home directory of the real or effective user.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-11-17 21:20 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 10:07 [PATCH] Expand ~ and ~user in core.excludesfile, commit.template Matthieu Moy
2009-11-16 22:49 ` Junio C Hamano
2009-11-17 6:49 ` Junio C Hamano
2009-11-17 8:59 ` Matthieu Moy
2009-11-16 23:47 ` Jakub Narebski
2009-11-17 6:22 ` Junio C Hamano
2009-11-17 8:57 ` Matthieu Moy
2009-11-17 13:30 ` Jakub Narebski
2009-11-17 9:30 ` Jakub Narebski
2009-11-17 7:34 ` Jeff King
2009-11-17 7:49 ` Mike Hommey
2009-11-17 21:20 ` Andreas Schwab [this message]
2009-11-17 22:16 ` Junio C Hamano
2009-11-18 0:42 ` Andreas Schwab
2009-11-18 7:24 ` Matthieu Moy
2009-11-17 8:53 ` Matthieu Moy
2009-11-17 8:56 ` Jeff King
2009-11-17 17:24 ` [PATCH v2] " Matthieu Moy
2009-11-18 7:29 ` [PATCH v3] " Matthieu Moy
2009-11-18 8:58 ` [PATCH v4] " Matthieu Moy
2009-11-19 15:21 ` [PATCH] expand_user_path: expand ~ to $HOME, not to the actual homedir Matthieu Moy
2009-11-19 15:23 ` Jeff King
2009-11-19 16:32 ` Matthieu Moy
2009-11-19 18:12 ` [PATCH v4] Expand ~ and ~user in core.excludesfile, commit.template Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lji43l20.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=mh@glandium.org \
--cc=peff@peff.net \
--cc=quarl@quarl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).