From: Andreas Schwab <schwab@linux-m68k.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ross Lagerwall <rosslagerwall@gmail.com>,
git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] rev-parse --show-prefix: add in trailing newline
Date: Tue, 10 Apr 2012 16:41:45 +0200 [thread overview]
Message-ID: <m2vcl7ir86.fsf@igel.home> (raw)
In-Reply-To: <7v1unwwwov.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 09 Apr 2012 12:07:44 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Because the assignment will strip the trailing LF away
No, it doesn't. Command substitution does.
> But it will break existing scripts if they expect the following to work:
>
> file="$(git rev-parse --show-prefix)/$1"
> cd_to_toplevel
> test -f "$file"
This is already broken because of the extra slash.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2012-04-10 14:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 13:27 [PATCH] rev-parse --show-prefix: add in trailing newline Ross Lagerwall
2012-04-09 19:07 ` Junio C Hamano
2012-04-10 5:30 ` Ross Lagerwall
2012-04-10 14:04 ` Jonathan Nieder
2012-04-10 14:41 ` Andreas Schwab [this message]
2012-04-10 16:14 ` Junio C Hamano
2012-04-10 17:36 ` Jonathan Nieder
2012-04-10 17:56 ` Junio C Hamano
2012-04-10 22:51 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vcl7ir86.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=rosslagerwall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).