From: Andreas Schwab <schwab@linux-m68k.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] sha1_file.c: zlib can only process 4GB at a time
Date: Wed, 08 Jun 2011 21:16:44 +0200 [thread overview]
Message-ID: <m2vcwgf80z.fsf@igel.home> (raw)
In-Reply-To: <7v1uz42liw.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Wed, 08 Jun 2011 12:03:35 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> +#define ZLIB_BUF_MAX ((1UL << ((sizeof(uInt) * 8))) - 1)
This is undefined if unsigned long has 32 bits.
#define ZLIB_BUF_MAX ((uInt)-1)
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-06-08 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 19:03 [PATCH] sha1_file.c: zlib can only process 4GB at a time Junio C Hamano
2011-06-08 19:16 ` Andreas Schwab [this message]
2011-06-09 20:11 ` [PATCH] unpack-objects: " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2vcwgf80z.fsf@igel.home \
--to=schwab@linux-m68k.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).