git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] prepare deprecation of git-revert
Date: Fri, 31 Oct 2008 09:36:33 -0700 (PDT)	[thread overview]
Message-ID: <m33aichgc1.fsf@localhost.localdomain> (raw)
In-Reply-To: <1225468527-29694-1-git-send-email-madcoder@debian.org>

Pierre Habouzit <madcoder@debian.org> writes:

> * Rename builtin-revert.c into builtin-cherry-pick.c
> 
> * Add option -R/--revert to git-cherry-pick.
>   Document it by taking the current content of git-revert manpage for the
>   option.
> 
> * get rid of the no_replay initialization, just ignore it when we're in
>   the revert case, it makes really no sense to error out.
> 
> * put the warning of deprecation in cmd_revert, #if 0-ed out for now.

> +#if 0
> +	warning("git revert is deprecated, please use git cherry-pick --revert/-R instead");
> +#endif

By the way, Mercurial names this command IIRC 'hg backout'. 

But I think that adding '-R' option to git-cherry-pick is a good idea
even if we don't go deprecating git-revert.
-- 
Jakub Narebski
Poland
ShadeHawk on #git

  parent reply	other threads:[~2008-10-31 16:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31 15:55 [PATCH] prepare deprecation of git-revert Pierre Habouzit
2008-10-31 15:57 ` Pierre Habouzit
2008-10-31 16:36 ` Jakub Narebski [this message]
2008-10-31 16:54   ` Pierre Habouzit
2008-10-31 19:01   ` Theodore Tso
2008-11-01 11:53     ` Andreas Ericsson
2008-10-31 16:50 ` Alex Riesen
2008-10-31 16:58   ` Pierre Habouzit
2008-10-31 23:24     ` Alex Riesen
2008-10-31 23:13   ` Johannes Schindelin
2008-10-31 23:20     ` Junio C Hamano
2008-11-01 23:01       ` Matthieu Moy
2008-11-02  9:32   ` Nguyen Thai Ngoc Duy
2008-11-02 16:12     ` Johannes Schindelin
2008-11-02  4:41 ` Jeff King
2008-11-02  9:30   ` Pierre Habouzit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33aichgc1.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=madcoder@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).