From: Jakub Narebski <jnareb@gmail.com>
To: Ben Aurel <ben.aurel@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Error: "You have some suspicious patch lines"
Date: Tue, 22 Jul 2008 02:13:05 -0700 (PDT) [thread overview]
Message-ID: <m33am2wade.fsf@localhost.localdomain> (raw)
In-Reply-To: <4885895C.5050108@gmail.com>
Ben Aurel <ben.aurel@gmail.com> writes:
> I working on mac os x 10.5.4 (intel) with git version 1.5.5.3 and I
> always get this message for most of my perl scripts and also for
> "Makefile.pre" files:
>
> ----------- Message ---------------
> * You have some suspicious patch lines:
> *
> * In src/scripts/trunk/3rdparty/file_sanity.pl
> * trailing whitespace (line 52)
> ...
> ------------------------------------------
> The question now is: Is it really necessary to edit the git script
> everytime? Is there a urgent reason why git refuses to commit because
> of "suspicious" lines? Is it really necessary?
.git/hooks/pre-commit is example hook which helps to keep Coding Style,
and prevents from accidentally comitting nonresolved file-level merge
conflict (file with conflict markers).
If you want to skip running this hook once (or once upon a time), you
can use '-n'/'--no-verify' option to "git commit". Or you can turn this
example hook off, either by removing execute permission from it, by
removing it alltogether (you can still find it in templates, usually at
/usr/share/git-core/templates/hooks/pre-commit), or rename it adding for
example '.sample' or '.nonactive' suffix.
This hook should not be turned on by default, but if your filesystem is
executing bit challenged it could be turned on at repository creation
time unintentionally. Newer version of git use '.sample' suffix (for
example pre-commit.sample) instead of relying on not always reliable
execute bit being unset.
HTH
--
Jakub Narebski
Poland
ShadeHawk on #git
prev parent reply other threads:[~2008-07-22 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 7:16 Error: "You have some suspicious patch lines" Ben Aurel
2008-07-22 7:26 ` Jeff King
2008-07-22 9:13 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m33am2wade.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=ben.aurel@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).