From: Jakub Narebski <jnareb@gmail.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Дилян Палаузов" <dilyan.palauzov@aegee.org>,
git@vger.kernel.org
Subject: Re: 1.7.9, libcharset missing from EXTLIBS
Date: Fri, 10 Feb 2012 05:15:34 -0800 (PST) [thread overview]
Message-ID: <m37gzuvni4.fsf@localhost.localdomain> (raw)
In-Reply-To: <CACBZZX45=mr=FMqFF+Pw4KPaDAtvs-ePLbFATpyFA93vSfZatw@mail.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> 2012/2/10 Junio C Hamano <gitster@pobox.com>:
>> Дилян Палаузов <dilyan.palauzov@aegee.org> writes:
>>> git 1.7.9 makes use of libcharset and /Makefile contains:
> >>
>>> ifdef HAVE_LIBCHARSET_H
>>> BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
>>> endif
>>> ...
>>> and the problem is, that libcharset is not used when linking. To
>>> solve this, please replace the above extract from /Makefile with
>>>
>>> ifdef HAVE_LIBCHARSET_H
>>> BASIC_CFLAGS += -DHAVE_LIBCHARSET_H
>>> EXTLIBS += -lcharset
>>> endif
[....]
> I've had some similar (privately sent) bug reports about the i18n
> stuff from someone who built his own Linux distro.
>
> Basically we make assumptions that certain stuff will be in the C
> library on certain platforms, certain headers go with certain
> libraries etc.
>
> Evidently none of this can really be relied upon and we'd have to
> probe for each one if we wanted to make it reliable.
Well, there is always *optional* configure.ac to do detection;
"make configure; ./configure <options>" will generate config.mak.autogen
with appropriate options -- we can add autodetection if -lcharset
must be added.
--
Jakub Narębski
prev parent reply other threads:[~2012-02-10 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 1:29 1.7.9, libcharset missing from EXTLIBS Дилян Палаузов
2012-02-10 2:13 ` Junio C Hamano
2012-02-10 10:06 ` Ævar Arnfjörð Bjarmason
2012-02-10 10:21 ` Дилян Палаузов
2012-02-10 18:35 ` Junio C Hamano
2012-02-10 19:52 ` Dilyan Palauzov
2012-02-10 20:10 ` Erik Faye-Lund
2012-02-10 20:25 ` Junio C Hamano
2012-02-12 0:55 ` Дилян Палаузов
2012-02-12 1:03 ` Ævar Arnfjörð Bjarmason
2012-02-12 10:30 ` Junio C Hamano
2012-02-12 16:23 ` [PATCH] " Дилян Палаузов
2012-02-10 13:15 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m37gzuvni4.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=avarab@gmail.com \
--cc=dilyan.palauzov@aegee.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).