From: Jakub Narebski <jnareb@gmail.com>
To: John Goerzen <jgoerzen@complete.org>
Cc: git@vger.kernel.org, Sam Vilain <sam@vilain.net>,
	Juan Jose Comellas <juanjo@comellas.org>
Subject: Re: FastCGI support in gitweb
Date: Tue, 04 Mar 2008 09:22:45 -0800 (PST)	[thread overview]
Message-ID: <m37igiietq.fsf@localhost.localdomain> (raw)
In-Reply-To: <slrnfsqoai.njm.jgoerzen@katherina.lan.complete.org>
The following message is a courtesy copy of an article
that has been posted to gmane.comp.version-control.git as well.
[Cc: Sam Vilain, Juan Jose Comellas]
John Goerzen <jgoerzen@complete.org> writes:
> FastCGI is much, much lighter on resource requirements if you are
> deploying apps written in various languages on a single server.
> Sometimes even if you aren't.
If you want to add FastCGI support to gitweb, besides fulfilling
constraints I have mentioned earlier (it must run as CGI and mod_perl,
must run without CGI::Fast / FCGI), I think it would be best to
separate input validation and dispatch into separate subroutine.
Perhaps even going as far as getting only required input in the
"action" routines, for example
  our ($hash, $hash_base) = gitweb_params('hash', 'hash_base');
at the beginning of git_commit() subroutine, etc.
-- 
Jakub Narebski
Poland
ShadeHawk on #git
     prev parent reply	other threads:[~2008-03-04 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-01 21:34 FastCGI support in gitweb Juan Jose Comellas
2008-03-01 21:50 ` Jakub Narebski
2008-03-03 12:28   ` Sam Vilain
2008-03-04  0:19     ` Jakub Narebski
2008-03-04  3:59       ` John Goerzen
2008-03-04 10:11         ` Jakub Narebski
2008-03-04 14:48           ` John Goerzen
2008-03-04 17:22             ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=m37igiietq.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jgoerzen@complete.org \
    --cc=juanjo@comellas.org \
    --cc=sam@vilain.net \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).