Git development
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Feb 2012, #08; Wed, 22)
Date: Thu, 23 Feb 2012 03:29:06 -0800 (PST)	[thread overview]
Message-ID: <m38vjteqkj.fsf@localhost.localdomain> (raw)
In-Reply-To: <7vfwe26zwn.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

> * jn/gitweb-hilite-regions (2012-02-19) 5 commits
>  - gitweb: Use esc_html_match_hl() in 'grep' search

This one is about starting unification of match highlighting in
gitweb, using esc_html_match_hl() which can show multiple matches in
line as opposed to existing hand-crafted and duplicated solutions.

>  - gitweb: Highlight matched part of shortened project description
>  - gitweb: Highlight matched part of project description when searching projects
>  - gitweb: Highlight matched part of project name when searching projects
>  - gitweb: Introduce esc_html_hl_regions

This is about adding match highlighting to project search.  Other
kinds of search in gitweb ('commit', 'grep' - both per-repository
searches) already use match highlighting.

>  (this branch uses jn/gitweb-search-optim.)

Theoretically those topics should be independent, but I think there
can be tetual conflict.  Better to build one on top of the other.

Nb. should I send those series independently?
 
> Not reviewed and do not know what this is about yet ;-).

I hope that above description helps.
 
> * jn/gitweb-search-optim (2012-02-19) 3 commits
>  - gitweb: Faster project search
>  - gitweb: Option for filling only specified info in fill_project_list_info
>  - gitweb: Refactor checking if part of project info need filling
>  (this branch is used by jn/gitweb-hilite-regions.)
> 
> The API introduced in the second step still has yucky design, but at least
> it is more clear than the previous rounds what this is trying to do.

Thanks for the comments.  I'll try to send re-roll soon.

-- 
Jakub Narebski

      reply	other threads:[~2012-02-23 11:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  2:34 What's cooking in git.git (Feb 2012, #08; Wed, 22) Junio C Hamano
2012-02-23 11:29 ` Jakub Narebski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m38vjteqkj.fsf@localhost.localdomain \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox