Re: [PATCH 04/16] update-index: add --checkout/--no-checkout to update CE_NO_CHECKOUT bit

[Jakub Narebski <jnareb@gmail.com>]

I will comment only on documentation...

Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:

> --- a/Documentation/git-update-index.txt
> +++ b/Documentation/git-update-index.txt
> @@ -15,6 +15,7 @@ SYNOPSIS
>  	     [--cacheinfo <mode> <object> <file>]\*
>  	     [--chmod=(+|-)x]
>  	     [--assume-unchanged | --no-assume-unchanged]
> +	     [--checkout | --no-checkout]
>  	     [--ignore-submodules]
>  	     [--really-refresh] [--unresolve] [--again | -g]
>  	     [--info-only] [--index-info]
> @@ -88,6 +89,17 @@ OPTIONS
>  	sometimes helpful when working with a big project on a
>  	filesystem that has very slow lstat(2) system call
>  	(e.g. cifs).
> +--checkout::
> +--no-checkout::
> +	When these flags are specified, the object name recorded
> +	for the paths are not updated. Instead, these options
> +	set and unset the "no-checkout" bit for the paths. This
> +	bit is used for marking files for narrow checkout. If
> +	a path is marked "no-checkout", then it should not be
> +	checked out unless requested by user or needed for a git
> +	command to function.
> +	See linkgit:git-checkout[1] for more information about
> +	narrow checkout.

Low level (porcelain) access to "no checkout" bit/flag, isn't it?

Nice. One caveat: you refer to git-checkout(1), which I think is
updated to include referenced information only later in the series.
Perhaps add "See linkgit:git-checkout[1]..." part only _after_ the
referenced information is in Documentation/git-checkout.txt

>  +
>  This option can be also used as a coarse file-level mechanism
>  to ignore uncommitted changes in tracked files (akin to what

Ooops. It looks like it is continuation line to _previous_ option,
probably --assume-unchanged, which you have interrupted by mistake.

-- 
Jakub Narebski
Poland
ShadeHawk on #git