From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Miles Bader <miles@gnu.org>, Michael Witten <mfwitten@gmail.com>,
git@vger.kernel.org
Subject: Re: Dates in Commits and other issues of style (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL)
Date: Mon, 25 Apr 2011 03:45:03 -0700 (PDT) [thread overview]
Message-ID: <m3bozuwqyz.fsf@localhost.localdomain> (raw)
In-Reply-To: <7vhb9nkmo1.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> Enforcing consistency is one of the important tasks the maintainers do in
> their projects. Besides ensuring that the intent of the change each patch
> brings to the codebase is good, that the log entry describes the change in
> a useful way for future readers, and that the patch correctly implements
> the described change, we also need to make sure that the resulting code
> matches the style of the surrounding code, and the style, structure and
> tone the log messages are delivered in a consistent voice. Otherwise it
> would quickly get very tiring when you have to dig into the history of the
> codebase. The code and the history are read a lot more often than are
> written. [...]
This information should be put e.g. in SubmittingPatches, or
CodingGuidelines, or MaintNotes, isn't it?
--
Jakub Narebski
Poland
ShadeHawk on #git
next prev parent reply other threads:[~2011-04-25 10:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 2:53 [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local Michael Witten
2011-04-20 2:45 ` [RFC 1/5] Light refactoring of date infrastructure Michael Witten
2011-04-20 2:45 ` [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL Michael Witten
2011-04-21 22:34 ` Junio C Hamano
2011-04-22 14:08 ` Dates in Commits and other issues of style (Re: [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL) Michael Witten
2011-04-25 1:26 ` Miles Bader
2011-04-25 3:57 ` Junio C Hamano
2011-04-25 10:45 ` Jakub Narebski [this message]
2011-04-25 18:29 ` Junio C Hamano
2011-04-22 14:36 ` [RFC 2/5] Pretty Print: show tz when using DATE_LOCAL Michael Witten
2011-04-22 15:06 ` Junio C Hamano
2011-04-20 2:45 ` [RFC 3/5] Date Mode: Implementation Michael Witten
2011-04-21 22:44 ` Junio C Hamano
2011-04-20 2:45 ` [RFC 4/5] Date Mode: Documentation Michael Witten
2011-04-20 2:45 ` [RFC 5/5] Date Mode: Tests Michael Witten
2011-04-21 22:44 ` Junio C Hamano
2011-04-23 3:42 ` Michael Witten
2011-04-23 5:06 ` Michael Witten
2011-04-23 3:45 ` Time zone option name (Re: [RFC 5/5] Date Mode: Tests) Michael Witten
2011-04-23 5:27 ` Junio C Hamano
2011-04-23 3:59 ` [RFC 5/5] Date Mode: Tests Michael Witten
2011-04-20 6:43 ` [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local Jeff King
2011-04-20 14:21 ` Michael Witten
2011-04-21 1:50 ` Junio C Hamano
2011-04-21 2:14 ` Michael Witten
2011-04-21 3:57 ` Junio C Hamano
2011-04-21 4:09 ` Michael Witten
2011-04-20 14:22 ` Michael Witten
2011-04-20 14:22 ` Michael Witten
2011-04-20 14:23 ` Michael Witten
2011-04-21 0:07 ` Tabs and spaces (Re: [RFC 0/5] Date Mode: Add --time-zone; deprecate --date=local) Jonathan Nieder
2011-04-21 1:51 ` Tabs and spaces Michael Witten
2011-04-21 2:18 ` Jonathan Nieder
2011-04-21 3:15 ` Michael Witten
2011-04-21 3:25 ` Thiago Farina
2011-04-21 10:46 ` Alex Riesen
2011-04-21 12:57 ` Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3bozuwqyz.fsf@localhost.localdomain \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mfwitten@gmail.com \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).